[Docs] fixing KibanaPageTemplate docs #100104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myasonik
added
v8.0.0
release_note:skip
glitteringkatie
approved these changes
May 14, 2021
There was a problem hiding this comment.
Unsure about all that broken build stuff 👀 But from a docs standpoint, this works and I'm able to click the link in building_blocks and move over to the kpt page! AND I learned a really cool thing that Just Works™ in at least the gatsby system: by using the following object in my sources-dev.json I was able to test your branch without having kibana locally 🤩
{
"type": "github",
"location": "myasonik/kibana",
"branch": "fix-docs"
}
|
@elasticmachine merge upstream |
gtback
approved these changes
May 14, 2021
💛 Build succeeded, but was flaky
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 14, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
May 14, 2021
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 17, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 25, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating all instances of
KibanaPageLayouttoKibanaPageTemplateand fixing any related slugs/ids