Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FTR] Clean navigateToApp #100144

Merged
merged 2 commits into from
May 17, 2021
Merged

[FTR] Clean navigateToApp #100144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2a221d
remove non-valid code
dmlemeshko May 14, 2021
7e7fee0
Merge branch 'master' into ftr-navigation-cleanup
kibanamachine May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions test/functional/page_objects/common_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
return currentUrl;
});

await retry.try(async () => {
await retry.tryForTime(defaultFindTimeout, async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LeeDr I think we should shorten timeout for url validation from 120 sec = try: Joi.number().default(120000) to 10 sec =find: Joi.number().default(10000): the logic here is that we wait for url to stop changing.
My guess is that it shouldn't take too long for re-direction/url change, and if it is happening we better fail fast.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how, but ciGroups ran 1-2 min faster vs my other PR with no navigation changes.

guess it is related

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reducing any timeouts, we just have to be careful about running tests on Cloud. I think Kibana can appear to stall when an index snapshot is happening.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this could be the case. Let's see how it goes, but the global navigation timeout remains the same.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, I don't expect it to fail on cloud and if it will, then we should check performance of cloud instances.

await this.sleep(501);
const currentUrl = await browser.getCurrentUrl();
log.debug('in navigateTo url = ' + currentUrl);
Expand All @@ -266,10 +266,6 @@ export function CommonPageProvider({ getService, getPageObjects }: FtrProviderCo
throw new Error('URL changed, waiting for it to settle');
}
});
if (appName === 'status_page') return;
if (await testSubjects.exists('statusPageContainer')) {
throw new Error('Navigation ended up at the status page.');
}
});
}

Expand Down