Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] update code coverage to use its own script #100199

Merged
merged 5 commits into from
May 20, 2021
Merged

[QA] update code coverage to use its own script #100199

merged 5 commits into from
May 20, 2021

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented May 17, 2021 •
edited
Loading

Summary

Fixing code coverage pipeline. It was failing because build artefacts are not available for upload which is the new default behaviour. Instead of adding condition, I moved logic into separate bash file and added a new function in coverage groovy lib to call it.

Tested https://kibana-ci.elastic.co/view/Kibana/job/elastic+kibana+qa-research/223/

21:01:33  ### debug COVERAGE_JOB_NAME: elastic+kibana+qa-research
21:01:33  ### debug CI_RUN_URL: https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/223/
21:01:33  ### debug FETCHED_PREVIOUS: e99cfb5c0ba
21:01:48  ### Ingesting coverage for functional
21:01:48  ### Ingesting coverage for jest
21:06:00  ###  Ingesting Code Coverage - Complete

@dmlemeshko dmlemeshko added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels May 19, 2021
@dmlemeshko dmlemeshko marked this pull request as ready for review May 19, 2021 18:26
@dmlemeshko dmlemeshko requested a review from a team as a code owner May 19, 2021 18:26
@dmlemeshko
Copy link
Member Author

@LeeDr @wayneseymour could you review?

@dmlemeshko
Copy link
Member Author

@elasticmachine merge upstream

marius-dr
marius-dr approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
stackAlerts 101 95 -6
total -295

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko merged commit bc3b9d6 into elastic:master May 20, 2021
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@dmlemeshko @kibanamachine @yctercero
[QA] update code coverage to use its own script (elastic#100199)
20a0750 
* do  run build script for code coverage

* fix notifyOnError call

* remove maxWorkers argument

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@dmlemeshko dmlemeshko deleted the move-code-coverage-to-its-own-script branch January 31, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marius-dr marius-dr marius-dr approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmlemeshko @kibanamachine @marius-dr