Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update detection rule telemetry field name. #100256

Merged
merged 5 commits into from
May 18, 2021
Merged

Update detection rule telemetry field name. #100256

merged 5 commits into from
May 18, 2021

Conversation

clburn-elastic
Copy link
Contributor

@clburn-elastic clburn-elastic commented May 18, 2021 •
edited by pjhampton
Loading

Summary

Update detection rule telemetry field name.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@clburn-elastic clburn-elastic self-assigned this May 18, 2021
@clburn-elastic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
crossClusterReplication 8 6 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @clburn-elastic

@clburn-elastic clburn-elastic marked this pull request as ready for review May 18, 2021 14:18
@clburn-elastic clburn-elastic requested review from a team as code owners May 18, 2021 14:18
@clburn-elastic clburn-elastic added the auto-backport Deprecated - use backport:version if exact versions are needed label May 18, 2021
pjhampton
pjhampton approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@pjhampton pjhampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌔 🚀 ✨ LGTM ✨ 🚀 🌔

I have checked out the branch and triggered the usage collector. The output looks good to me. Thanks for this change!

@clburn-elastic clburn-elastic enabled auto-merge (squash) May 18, 2021 14:34
@pjhampton pjhampton added the release_note:skip Skip the PR/issue when compiling release notes label May 18, 2021
Bamieh
Bamieh approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If this data is being reported in previous versions we'd need to handle moving it from cases_count_daily to cases_count_total on the telemetry cluster by opening an infra ticket.

@clburn-elastic
Copy link
Contributor Author

LGTM. If this data is being reported in previous versions we'd need to handle moving it from cases_count_daily to cases_count_total on the telemetry cluster by opening an infra ticket.

Thanks so much for taking a look at this! I can confirm that this telemetry is all new for the 7.13 release, but I really appreciate the heads-up on the infra ticket. :)

FrankHassanabad
FrankHassanabad approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM-Lay, That's pig latin for LGTM

@clburn-elastic clburn-elastic merged commit 6f31c10 into master May 18, 2021
@pjhampton pjhampton added auto-backport Deprecated - use backport:version if exact versions are needed and removed auto-backport Deprecated - use backport:version if exact versions are needed labels May 19, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request May 19, 2021
@clburn-elastic @kibanamachine
Update detection rule telemetry field name. (elastic#100256)
ad35336 
* Changing variable name of cases_count_daily to cases_count_total.

* Taking comments out of tests and reverting tests to previosu state.

* Changing meta description to be more descriptive.

* Changing meta description to be more descriptive.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request May 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.13

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 19, 2021
@kibanamachine @clburn-elastic
Update detection rule telemetry field name. (#100256) (#100315)
bb1c00d 
* Changing variable name of cases_count_daily to cases_count_total.

* Taking comments out of tests and reverting tests to previosu state.

* Changing meta description to be more descriptive.

* Changing meta description to be more descriptive.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Claire Burn <80253545+clburn-elastic@users.noreply.github.com>
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@clburn-elastic @kibanamachine @yctercero
Update detection rule telemetry field name. (elastic#100256)
1b96a2f 
* Changing variable name of cases_count_daily to cases_count_total.

* Taking comments out of tests and reverting tests to previosu state.

* Changing meta description to be more descriptive.

* Changing meta description to be more descriptive.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@pjhampton pjhampton mentioned this pull request May 28, 2021
Merged
pjhampton added a commit that referenced this pull request May 28, 2021
@pjhampton @clburn-elastic @kibanamachine
Update detection rule telemetry field name. (#100256) (#100910)
29e0969 
* Changing variable name of cases_count_daily to cases_count_total.

* Taking comments out of tests and reverting tests to previosu state.

* Changing meta description to be more descriptive.

* Changing meta description to be more descriptive.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Claire Burn <80253545+clburn-elastic@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@pjhampton pjhampton mentioned this pull request Nov 18, 2021
Closed
1 task
@spalger spalger deleted the update-cases-key-and-telemetry-testing branch May 8, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

@Bamieh Bamieh Bamieh approved these changes

@pjhampton pjhampton pjhampton approved these changes

Assignees

@clburn-elastic clburn-elastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Telemetry release_note:fix release_note:skip Skip the PR/issue when compiling release notes v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clburn-elastic @kibanamachine @FrankHassanabad @Bamieh @pjhampton