Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solutions] Removes commented out "last look back date" code #100269

Merged
merged 2 commits into from
May 18, 2021
Merged

[Security Solutions] Removes commented out "last look back date" code #100269

merged 2 commits into from
May 18, 2021

Conversation

FrankHassanabad
Copy link
Contributor

@FrankHassanabad FrankHassanabad commented May 18, 2021 •
edited
Loading

Summary

  • Removes commented out code which promises we are going to do something past 7.11. This code has been checked in and the column of last_look_back_date has been removed since 7.11, which means we haven't had it for 7.11, 7.12, and now 7.13.

Related: #89801

@FrankHassanabad FrankHassanabad requested a review from a team as a code owner May 18, 2021 15:16
@FrankHassanabad FrankHassanabad self-assigned this May 18, 2021
@FrankHassanabad FrankHassanabad added v8.0.0 v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This commit does not require backporting labels May 18, 2021
@FrankHassanabad FrankHassanabad changed the title [Security Solutions] Removes commented out code [Security Solutions] Removes commented out last look back date code May 18, 2021
@FrankHassanabad FrankHassanabad changed the title [Security Solutions] Removes commented out last look back date code [Security Solutions] Removes commented out "last look back date" code May 18, 2021
dhurley14
dhurley14 approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@dhurley14 dhurley14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the cleanup :)

@FrankHassanabad FrankHassanabad enabled auto-merge (squash) May 18, 2021 17:13
@kibanamachine
Copy link
Contributor

kibanamachine commented May 18, 2021 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

Kibana Pipeline / general / "before all" hook for "should not allow user with read only privileges to attach alerts to cases".Alerts timeline Privileges: read only "before all" hook for "should not allow user with read only privileges to attach alerts to cases"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: Expected <span.euiLoadingContent> not to exist in the DOM, but it was continuously found.

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Alerts timeline`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Object.waitForAlertsPanelToBeLoaded (http://localhost:61191/__cypress/tests?p=cypress/integration/detection_alerts/attach_to_case.spec.ts:19450:43)
    at Context.eval (http://localhost:61191/__cypress/tests?p=cypress/integration/detection_alerts/attach_to_case.spec.ts:18539:18)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.8MB 6.8MB -177.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
maps 286 208 -78
ml 121 115 -6
stackAlerts 101 95 -6
total -242

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@FrankHassanabad FrankHassanabad merged commit 79b2c58 into elastic:master May 18, 2021
@FrankHassanabad FrankHassanabad mentioned this pull request May 18, 2021
Merged
@FrankHassanabad FrankHassanabad removed the auto-backport Deprecated - use backport:version if exact versions are needed label May 18, 2021
@FrankHassanabad FrankHassanabad deleted the remove-table-feature branch May 18, 2021 17:51
FrankHassanabad added a commit that referenced this pull request May 18, 2021
@FrankHassanabad
[Security Solutions] Removes commented out "last look back date" code (…
c48d613 
…#100269) (#100281)

## Summary

* Removes commented out code which promises we are going to do something past 7.11. This code has been checked in and the column of `last_look_back_date` has been removed since 7.11, which means we haven't had it for 7.11, 7.12, and now 7.13.

Related: #89801
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@FrankHassanabad @yctercero
[Security Solutions] Removes commented out "last look back date" code (…
a42bd37 
…elastic#100269)

## Summary

* Removes commented out code which promises we are going to do something past 7.11. This code has been checked in and the column of `last_look_back_date` has been removed since 7.11, which means we haven't had it for 7.11, 7.12, and now 7.13.

Related: elastic#89801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley14 dhurley14 dhurley14 approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankHassanabad @kibanamachine @dhurley14