[Security Solutions] Re-arranges and adds more packages to remove copied code #100310

FrankHassanabad · 2021-05-19T05:02:24Z

Summary

Creates a securitysolution-list-utils packaged and moves the first set of utilities into there
Fixes a slight bug with kbn-securitysolution-io-ts-list-types where the wrong name was used
Moves all of the lists schemas and types into the package kbn-securitysolution-io-ts-list-types
Removes copied code found in a few places

Tech debt

Some spots I have to use an any in the package as Kibana kbn packages don't have the types I need
Some spots I copy constants until we can straighten out those pieces.
I keep copied mock files until we figure out how to share mocks from these packages without adding weight or we create dedicated mock packages for all of this.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…erall plugin and removed duplicated code

kibanamachine · 2021-05-19T19:55:47Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`lists`	194	210	+16
`securitySolution`	2104	2179	+75
total			+91

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`lists`	207	191	-16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lists`	55.2KB	74.4KB	+19.2KB
`securitySolution`	6.8MB	6.9MB	+72.9KB
total			+92.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`lists`	58	55	-3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`lists`	188.8KB	190.6KB	+1.8KB

Unknown metric groups

API count

id	before	after	diff
`lists`	229	210	-19

References to deprecated APIs

id	before	after	diff
`lists`	271	236	-35
`securitySolution`	389	380	-9
total			-44

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

elasticmachine · 2021-05-19T19:59:57Z

Pinging @elastic/security-detections-response (Team:Detections and Resp)

spong · 2021-05-19T20:04:51Z

.i18nrc.json

-      "src/plugins/management"
-    ],
+    "lists": "packages/kbn-securitysolution-list-utils/src",
+    "management": ["src/legacy/core_plugins/management", "src/plugins/management"],


Ping-pong on the auto-formatter...

Thanks, this change is so large I am going to leave it. Wish my editor hadn't done this.

spong · 2021-05-19T20:07:49Z

...n-securitysolution-io-ts-list-types/src/request/read_endpoint_list_item_schema/index.test.ts

+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.


For posterity -- the kbn packages use the newer v2 license but plugins do not, so that's why there's these license changes.

spong

LGTM! Thank you for all the heavy lifting here in moving everything around. It get's tedious, but makes a large impact, so thank you! 🙂

mistic

That LGTM after @jbudz windows testing

…ied code (elastic#100310) ## Summary * Creates a `securitysolution-list-utils` packaged and moves the first set of utilities into there * Fixes a slight bug with `kbn-securitysolution-io-ts-list-types` where the wrong name was used * Moves _all_ of the lists schemas and types into the package `kbn-securitysolution-io-ts-list-types` * Removes copied code found in a few places ## Tech debt * Some spots I have to use an `any` in the package as Kibana kbn packages don't have the types I need * Some spots I copy constants until we can straighten out those pieces. * I keep copied mock files until we figure out how to share mocks from these packages without adding weight or we create dedicated mock packages for all of this. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

kibanamachine · 2021-05-19T22:02:15Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…ied code (#100310) (#100369) ## Summary * Creates a `securitysolution-list-utils` packaged and moves the first set of utilities into there * Fixes a slight bug with `kbn-securitysolution-io-ts-list-types` where the wrong name was used * Moves _all_ of the lists schemas and types into the package `kbn-securitysolution-io-ts-list-types` * Removes copied code found in a few places ## Tech debt * Some spots I have to use an `any` in the package as Kibana kbn packages don't have the types I need * Some spots I copy constants until we can straighten out those pieces. * I keep copied mock files until we figure out how to share mocks from these packages without adding weight or we create dedicated mock packages for all of this. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>

…ied code (elastic#100310) ## Summary * Creates a `securitysolution-list-utils` packaged and moves the first set of utilities into there * Fixes a slight bug with `kbn-securitysolution-io-ts-list-types` where the wrong name was used * Moves _all_ of the lists schemas and types into the package `kbn-securitysolution-io-ts-list-types` * Removes copied code found in a few places ## Tech debt * Some spots I have to use an `any` in the package as Kibana kbn packages don't have the types I need * Some spots I copy constants until we can straighten out those pieces. * I keep copied mock files until we figure out how to share mocks from these packages without adding weight or we create dedicated mock packages for all of this. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

refs elastic/pull/100310/

…#128810) * Show creation success toast on adding first event filter fixes /issues/128444 * clean up redundant type imports refs /pull/100310/

Re-arranged and added packages

8cde065

FrankHassanabad self-assigned this May 19, 2021

FrankHassanabad added 8 commits May 19, 2021 06:40

Fixed e2e tests

e487a4f

Merge branch 'master' into add-more-list-packages

5f2e94d

Used import type in more areas

25ca889

Unexport things that are not needed to be exported

d86afb5

Merge branch 'master' into add-more-list-packages

f90b74a

Added new package for the list utils to begin reducing size of the ov…

b004023

…erall plugin and removed duplicated code

Merge branch 'master' into add-more-list-packages

60e9fc5

Fixes source root problem

16759a5

FrankHassanabad marked this pull request as ready for review May 19, 2021 19:59

FrankHassanabad requested review from a team as code owners May 19, 2021 19:59

FrankHassanabad added v8.0.0 v7.14.0 Team:Detections and Resp Security Detection Response Team labels May 19, 2021

FrankHassanabad added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels May 19, 2021

spong reviewed May 19, 2021

View reviewed changes

spong approved these changes May 19, 2021

View reviewed changes

mistic approved these changes May 19, 2021

View reviewed changes

FrankHassanabad changed the title ~~Re-arranged and added packages~~ [Security Solutions] Re-arranges and adds more packages to remove copied code May 19, 2021

jbudz approved these changes May 19, 2021

View reviewed changes

FrankHassanabad merged commit 9bf488e into elastic:master May 19, 2021

FrankHassanabad deleted the add-more-list-packages branch May 19, 2021 21:59

kibanamachine mentioned this pull request May 19, 2021

[7.x] [Security Solutions] Re-arranges and adds more packages to remove copied code (#100310) #100369

Merged

lizozom mentioned this pull request Jul 15, 2021

[Security] Use new package types in kbn-securitysolution-list-utils #105731

Closed

ashokaditya added a commit to ashokaditya/kibana that referenced this pull request Mar 29, 2022

clean up redundant type imports

1339441

refs elastic/pull/100310/

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solutions] Re-arranges and adds more packages to remove copied code #100310

[Security Solutions] Re-arranges and adds more packages to remove copied code #100310

FrankHassanabad commented May 19, 2021 •

edited

Loading

kibanamachine commented May 19, 2021

API count

References to deprecated APIs

elasticmachine commented May 19, 2021

spong May 19, 2021

FrankHassanabad May 19, 2021

spong May 19, 2021

spong left a comment

mistic left a comment

kibanamachine commented May 19, 2021

[Security Solutions] Re-arranges and adds more packages to remove copied code #100310

[Security Solutions] Re-arranges and adds more packages to remove copied code #100310

Conversation

FrankHassanabad commented May 19, 2021 • edited Loading

Summary

Tech debt

Checklist

kibanamachine commented May 19, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

References to deprecated APIs

History

elasticmachine commented May 19, 2021

spong May 19, 2021

Choose a reason for hiding this comment

FrankHassanabad May 19, 2021

Choose a reason for hiding this comment

spong May 19, 2021

Choose a reason for hiding this comment

spong left a comment

Choose a reason for hiding this comment

mistic left a comment

Choose a reason for hiding this comment

kibanamachine commented May 19, 2021

💚 Backport successful

FrankHassanabad commented May 19, 2021 •

edited

Loading