fix discover memory leak #100436
Closed
fix discover memory leak #100436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
Feature:Discover
markov00
reviewed
May 24, 2021
src/plugins/discover/public/application/angular/directives/histogram.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
|
@timroes could you review this as an interim solution? Thanks! |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
auto-merge was automatically disabled
June 7, 2021 14:42
Pull request was converted to draft
|
Will address memory leak in elastic/elastic-charts#1201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interim fix for discover memory leaks related to
@elastic/chartssee elastic/elastic-charts#1148.The main issue is that every new render creates a unique chart id and creates a new redux store along with many
re-reselectselectors.