Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default time ranges for better request caching #100536

Merged
merged 1 commit into from
May 26, 2021

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented May 25, 2021

Fixes #100344

This PR improves the defaults for quick time ranges to help with caching of historic data:

  • "Last 24 hours" will be rounded to the hour (now-24h/h to now)
  • "Last 7 days" will be rounded to the day (now-7d/d to now)
  • "Last 30 days" will be rounded to the day (now-30d/d to now)
  • "Last 90 days" will be rounded to the day (now-90d/d to now)
  • "Last 1 year" will be rounded to the day (now-1y/d to now)

This change will keep the "from" part of the time range stable if the user clicks refresh, leveraging the request cache on shards containing older data

@flash1293 flash1293 added release_note:enhancement v8.0.0 Team:AppServices v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 25, 2021
@flash1293 flash1293 changed the title Improve default time ranges Improve default time ranges for better request caching May 25, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 386 342 -44
stackAlerts 101 95 -6
total -342

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review May 25, 2021 11:53
@flash1293 flash1293 requested a review from a team as a code owner May 25, 2021 11:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@flash1293 flash1293 merged commit e7bc883 into elastic:master May 26, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 26, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 26, 2021
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 26, 2021
* master: (60 commits)
  [Docs] Index patterns REST API docs (elastic#100549)
  [Ingest pipelines] add support for fingerprint processor (elastic#100541)
  ping Core team when renovate bot bumps es client version (elastic#100662)
  [Maps] Add draw wizard (elastic#100278)
  Use documentation link service for index pattern field editor (elastic#100609)
  [Maps] filter dashboard by map extent (elastic#99860)
  [ftr] migrate screenshots and snapshots services to FtrService class (elastic#100514)
  fix anomaly functional test (elastic#100504)
  update breaking changes template to incorporate ES deprecations (elastic#100621)
  improve default time ranges (elastic#100536)
  [Gauge] Fixes wrong translations on ranges less than symbol (elastic#100535)
  [ftr] migrate "globalNav" service to FtrService class (elastic#100604)
  [ftr] migrate "testSubjects" to FtrService class (elastic#100512)
  Fix spaces test flakyness (elastic#100605)
  [Ingest pipelines] add support for ip type in convert processor (elastic#100531)
  [ftr] migrate "browser" to FtrService class (elastic#100507)
  [ftr] migrate "find" service to FtrService class (elastic#100509)
  [telemetry] report config deprecations (elastic#99887)
  [ftr] migrate "docTable" service to FtrService class (elastic#100595)
  [ftr] migrate "listingTable" service to FtrService class (elastic#100606)
  ...
ecezalp pushed a commit to ecezalp/kibana that referenced this pull request May 26, 2021
ecezalp pushed a commit to ecezalp/kibana that referenced this pull request May 26, 2021
@timroes timroes added the Feature:Timepicker Timepicker label Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Timepicker Timepicker release_note:enhancement v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change time filter quick ranges default settings
5 participants