[so-migrationsv2] Use named arguments in migrationsv2 actions #100964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
enhancement
mshustov
approved these changes
May 31, 2021
| /** @internal */ | ||
| export interface FetchIndicesParams { | ||
| client: ElasticsearchClient; | ||
| indicesToFetch: string[]; |
There was a problem hiding this comment.
optional: in sake of consistency: index: string[] or indices: string[]
| /** | ||
| * Since we don't run a search against the target index, we disable "refresh" to speed up | ||
| * the migration process. | ||
| * Although any further step must run "refresh" for the target index | ||
| * before we reach out to the MARK_VERSION_INDEX_READY step. | ||
| * Right now, it's performed during OUTDATED_DOCUMENTS_REFRESH step. | ||
| */ | ||
| false | ||
| ), | ||
| refresh: false, |
There was a problem hiding this comment.
optional: maybe we can make it optional with false default?
| sourceIndex: state.legacyIndex, | ||
| targetIndex: state.sourceIndex.value, | ||
| reindexScript: state.preMigrationScript, | ||
| requireAlias: false, |
There was a problem hiding this comment.
optional: I can't find whether it's used with other values. Maybe we should remove the parameter? The same for 60s in waitForReindexTask and waitForPickupUpdatedMappingsTask
pgayvallet
approved these changes
May 31, 2021
TinaHeiligers
added
the
auto-backport
💚 Build SucceededMetrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 31, 2021
…c#100964) * Use named arguments in migrationsv2 actions * Addresses some optional review feedback
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 1, 2021
… (#101023) * Use named arguments in migrationsv2 actions * Addresses some optional review feedback Co-authored-by: Christiane (Tina) Heiligers <christiane.heiligers@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #99242
Uses named arguments in saved object migrations v2 actions.
Naming is hard™ and the refactor uses the same argument names as the those used in the actions' function.
Checklist
Delete any items that are not applicable to this PR.
For maintainers