Fix bug with using title attribute in breadcrumbs directive. #10171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
Team:Platform-Design
| @@ -8,13 +8,15 @@ const module = uiModules.get('kibana'); | |||
| module.directive('breadCrumbs', function ($location) { | |||
| return { | |||
| restrict: 'E', | |||
| replace: true, | |||
There was a problem hiding this comment.
It will remove the <bread-crumbs> element from the DOM and instead only add the children (i.e. the DOM defined by the directive's template).
stacey-gammon
approved these changes
Feb 3, 2017
cjcenizal
pushed a commit
that referenced
this pull request
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breadcrumbs directive currently has a
titleattribute. This will be interpreted as a valid HTML attribute by browsers:This PR renames the attribute and also sets
replace: trueon the directive to reduce the depth of the node tree for this directive.