Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adds popover help for multiclass confusion matrix #101732

Merged
merged 7 commits into from
Jun 10, 2021
Merged

[ML] Adds popover help for multiclass confusion matrix #101732

merged 7 commits into from
Jun 10, 2021

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Jun 9, 2021 •
edited
Loading

Summary

This PR adds help for the "Normalized confusion matrix for the entire dataset" section of the classification exploration page, using an EUI popover.

Data_Frame_Analytics_-_Machine_Learning_-_Elastic

Data_Frame_Analytics_-_Machine_Learning_-_Elastic

Checklist

Delete any items that are not applicable to this PR.

@szabosteve szabosteve added enhancement New value added to drive a business result :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features v7.14.0 labels Jun 9, 2021
@szabosteve szabosteve requested a review from a team as a code owner June 9, 2021 11:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@lcawl
Copy link
Contributor

lcawl commented Jun 10, 2021

One other thing we mention in https://www.elastic.co/guide/en/machine-learning/current/flightdata-classification.html#flightdata-classification-evaluate that might be worth considering adding is this feature: "You can also use the Training and Testing filter options to refine the contents of the matrix. Thus you can see how well the model performs on previously unseen data." I believe the method for filtering the matrix changed in one of the releases, so it took me a bit to figure out how to do it again the last time I tried.

szabosteve and others added 2 commits June 10, 2021 08:02
@szabosteve @lcawl
Update x-pack/plugins/ml/public/application/data_frame_analytics/page…
2b4b2f2 
…s/analytics_exploration/components/classification_exploration/confusion_matrix_help_popover.tsx

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
@szabosteve
Merge branch 'master' of github.com:elastic/kibana into context.help.…
4fbb48e 
…matrix
@szabosteve
Copy link
Contributor Author

I believe the method for filtering the matrix changed in one of the releases, so it took me a bit to figure out how to do it again the last time I tried.

Yes, there is a selector in the top right corner of the page that can switch between Training/Testing. However, that toggle changes the context for the entire page, not only for the confusion matrix. For this reason, I wouldn't highlight it in the popover help of the confusion matrix. I added, however, a sentence about the fact that the user can see the exact number of occurrences if they select a cell in the matrix.

peteharverson
peteharverson reviewed Jun 10, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The popover text content looks good, but just added a small suggestion for the layout of the title section.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1691 1692 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.8MB 5.8MB +2.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

peteharverson
peteharverson approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lcawl
lcawl approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, congrats on your first awesome popover!

@szabosteve szabosteve merged commit 85fa7c8 into elastic:master Jun 10, 2021
@szabosteve szabosteve deleted the context.help.matrix branch June 10, 2021 15:38
@szabosteve szabosteve mentioned this pull request Jun 10, 2021
Merged
szabosteve added a commit that referenced this pull request Jun 10, 2021
@szabosteve @lcawl
[ML] Adds popover help for multiclass confusion matrix (#101732) (#10…
15fe0f9 
…1914)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@lcawl lcawl lcawl approved these changes

Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szabosteve @elasticmachine @lcawl @kibanamachine @peteharverson