Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Node Pipelines] Migrate to new page layout #101894

Merged
merged 9 commits into from
Jun 15, 2021
Merged

[Ingest Node Pipelines] Migrate to new page layout #101894

merged 9 commits into from
Jun 15, 2021

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Jun 10, 2021 •
edited
Loading

This PR migrates Ingest Node Pipelines to use the new page layout.

Related: #100748

Pipelines List

Screenshot 2021-06-10 at 15 47 50
Screenshot 2021-06-11 at 09 51 59
Screenshot 2021-06-10 at 15 48 49
Screenshot 2021-06-10 at 15 49 16

Pipelines Create

Screenshot 2021-06-10 at 15 50 48

Pipelines Edit

Screenshot 2021-06-10 at 15 51 50
Screenshot 2021-06-11 at 09 48 02
Screenshot 2021-06-10 at 15 52 31

Pipelines Clone

Screenshot 2021-06-10 at 15 53 34

Permissions Check

Screenshot 2021-06-15 at 11 32 34
Screenshot 2021-06-15 at 11 33 09

@sabarasaba sabarasaba self-assigned this Jun 10, 2021
@sabarasaba sabarasaba mentioned this pull request Jun 10, 2021
Closed
10 tasks
@sabarasaba sabarasaba added chore Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.14.0 v8.0.0 labels Jun 14, 2021
@sabarasaba sabarasaba marked this pull request as ready for review June 14, 2021 07:11
@sabarasaba sabarasaba requested a review from a team as a code owner June 14, 2021 07:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

@alisonelizabeth
Copy link
Contributor

@elasticmachine merge upstream

alisonelizabeth
alisonelizabeth requested changes Jun 14, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @sabarasaba! I left a few nits in the code, mostly around copy.

I'd also like to see the error and loading states related to the privileges check updated before approving. You can find this in app.tsx. I created a common PageError component in #101811 (still in review), which may be helpful to use here.

x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/main.tsx Outdated Show resolved Hide resolved
x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/empty_list.tsx Outdated Show resolved Hide resolved
x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_edit/pipelines_edit.tsx Outdated Show resolved Hide resolved
@sabarasaba
Copy link
Member Author

Thanks for having a look @alisonelizabeth! Good catch regarding the permissions check, I wasn't aware of it! I ended up just wrapping them both with EuiPageContent for now since it seemed simpler. But once your changes are in, I can go through the apps and implementing the new components where needed.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 687.6KB 687.1KB -473.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ingestPipelines 23.7KB 23.5KB -152.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

alisonelizabeth
alisonelizabeth approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest LGTM. Thanks @sabarasaba!

@sabarasaba sabarasaba merged commit a7709b4 into elastic:master Jun 15, 2021
@sabarasaba sabarasaba mentioned this pull request Jun 15, 2021
Merged
sabarasaba added a commit to sabarasaba/kibana that referenced this pull request Jun 15, 2021
@sabarasaba @kibanamachine
[Ingest Node Pipelines] Migrate to new page layout (elastic#101894)
71c28da 
* migrate pages to new layout

* fix linter errors

* update translation files

* Nicer try-again cta

* Fix lang and prettier

* small CR changes

* small linter fixes

* fix test copy

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
sabarasaba added a commit that referenced this pull request Jun 15, 2021
@sabarasaba @kibanamachine
[Ingest Node Pipelines] Migrate to new page layout (#101894) (#102212)
59a54c6 
* migrate pages to new layout

* fix linter errors

* update translation files

* Nicer try-again cta

* Fix lang and prettier

* small CR changes

* small linter fixes

* fix test copy

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jun 15, 2021
@sabarasaba @kibanamachine
[Ingest Node Pipelines] Migrate to new page layout (elastic#101894)
e4c108c 
* migrate pages to new layout

* fix linter errors

* update translation files

* Nicer try-again cta

* Fix lang and prettier

* small CR changes

* small linter fixes

* fix test copy

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

Assignees

@sabarasaba sabarasaba

Labels
chore Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sabarasaba @elasticmachine @alisonelizabeth @kibanamachine