remove unnecessary hack copying url string #101909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
mshustov
commented
Jun 11, 2021
| } | ||
|
|
||
| request.setUrl(urlCopy); | ||
| request.setUrl(url); | ||
|
|
||
| // We should update raw request as well since it can be proxied to the old platform |
There was a problem hiding this comment.
we should remove it as well
mshustov
commented
Jun 11, 2021
| @@ -102,24 +102,7 @@ export function adoptToHapiOnRequest(fn: OnPreRoutingHandler, log: Logger) { | |||
| appState.rewrittenUrl = appState.rewrittenUrl ?? request.url; | |||
|
|
|||
| const { url } = result; | |||
|
|
|||
| // TODO: Remove once we upgrade to Node.js 12! | |||
|
Pinging @elastic/kibana-core (Team:Core) |
mshustov
added
the
release_note:skip
watson
approved these changes
Jun 11, 2021
pgayvallet
approved these changes
Jun 11, 2021
Comment on lines
-117
to
-120
| let urlCopy = ''; | ||
| for (let i = 0; i < url.length; i++) { | ||
| urlCopy += url[i]; | ||
| } |
There was a problem hiding this comment.
I'm gonna show you what's called a pro-gamer move.
mshustov
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 11, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 11, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 14, 2021
* master: (68 commits) skip flaky suite (elastic#94043) skip flaky suite (elastic#102012) [esArchive] Persists updates for management/saved_objects/* (elastic#101992) skip flaky suite (elastic#101449) remove unnecessary hack (elastic#101909) [Exploratory View] Use human readable formats (elastic#101520) [Expressions] Refactor expression functions to use observables underneath (elastic#100409) [esArchives] Persist migrated Kibana archives (elastic#101950) [kbnArchiver] fix save to non-existent file (elastic#101974) [Enterprise Search] Add owner and description properties to kibana.json (elastic#101957) [DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (elastic#101696) [Observability] [Cases] Cases in the observability app (elastic#101487) [Alerting][Docs] Combine rule creation and management pages (elastic#101498) temporarily disable build-buddy [Fleet] Fix fleet server collector in case settings are not set (elastic#101752) [Event Log] Populated rule.* ECS fields for alert events. (elastic#101132) [APM] Fleet support for merging input.config values with other nested properties in the policy input (elastic#101690) Add comments to some alerting plugin public API items (elastic#101551) [Alerting][Docs] Moving alerting setup to its own page (elastic#101323) remove uptime public API, it's not used. (elastic#101799) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.