[Security Solution][Endpoint] Show Endpoint Host Isolation status on endpoint list #101961

paul-tavares · 2021-06-10T20:38:27Z

Summary

Shows the Isolation status (if any) next to the Agent Status on both the Endpoint list as well as the Endpoint Details flyout
Some adjustments to the data generator to create pending actions

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

…types are pending

…w-isolation-status-on-endpoint-list

…w-isolation-status-on-endpoint-list # Conflicts: # x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.ts # x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/selectors.ts

…tory

dasansol92 · 2021-06-15T10:18:48Z

x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.ts

+    const agentIdToPendingActions: AgentIdsPendingActions = new Map();
+
+    for (const pendingAction of pendingActions) {
+      agentIdToPendingActions.set(pendingAction.agent_id, pendingAction.pending_actions);


I assume you are ok keeping the last pending_actions in the pendingActions array, is it right?

You mean in the store if the code inside this try {} block throw's an error?

No, if you have the same pendingAction.agent_id twice (or more), you will overwrite it in the map. Just want to know if this is ok or not.

We should not have duplicate agent ids. The code here does dedup and I think the API also dedups, so we should not get into that state. but - if we did, the data (pending_actions) would still be the same, so overwriting would be ok.

thanks for the explanation 👍

dasansol92

Just added a question but it LGTM 🚢

…w-isolation-status-on-endpoint-list

elasticmachine · 2021-06-15T19:29:49Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

ashokaditya

🚀

x-pack/plugins/security_solution/common/endpoint/index_data.ts

x-pack/plugins/security_solution/common/endpoint/data_generators/fleet_action_generator.ts

kibanamachine · 2021-06-15T23:19:09Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2181	2184	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	6.9MB	6.9MB	+6.7KB

History

💚 Build #131512 succeeded 9e3734d
💔 Build #131136 failed 1d5522d
💔 Build #131018 failed 65530e1
💔 Build #130652 failed e8619d3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

…endpoint list (elastic#101961) * Add endpoint isolation status for when multiple actions of different types are pending * Refactored List to break out Agent status code to separate component * Generator improvements for how actions are generated for Endpoints * Add HTTP mock for fleet EPM packages (to silence console errors) * new `.updateCommonInfo()` method to generator (to regenerate stateful data)

kibanamachine · 2021-06-16T14:02:47Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…endpoint list (#101961) (#102348) * Add endpoint isolation status for when multiple actions of different types are pending * Refactored List to break out Agent status code to separate component * Generator improvements for how actions are generated for Endpoints * Add HTTP mock for fleet EPM packages (to silence console errors) * new `.updateCommonInfo()` method to generator (to regenerate stateful data) Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com>

…endpoint list (elastic#101961) * Add endpoint isolation status for when multiple actions of different types are pending * Refactored List to break out Agent status code to separate component * Generator improvements for how actions are generated for Endpoints * Add HTTP mock for fleet EPM packages (to silence console errors) * new `.updateCommonInfo()` method to generator (to regenerate stateful data)

* mark for refactor refs elastic/security-team/issues/1407 refs /pull/101961/files * update comments review change

* mark for refactor refs elastic/security-team/issues/1407 refs elastic/pull/101961/files * update comments review change

* mark for refactor refs elastic/security-team/issues/1407 refs /pull/101961/files * update comments review change Co-authored-by: Ashokaditya <am.struktr@gmail.com>

* mark for refactor refs elastic/security-team/issues/1407 refs elastic/pull/101961/files * update comments review change

* mark for refactor refs elastic/security-team/issues/1407 refs /pull/101961/files * update comments review change

paul-tavares added 6 commits June 9, 2021 15:41

Add endpoint isolation status for when multiple actions of different …

2f5ed45

…types are pending

Merge remote-tracking branch 'upstream/master' into task/olm-1246-sho…

4433b5a

…w-isolation-status-on-endpoint-list

Refactored List to break out Agent status code to separate component

564f7cb

Store setup for retrieving pending actions

2730ec8

Refactor console.error usages in middleware

6aca956

Add reducer to store pending actions in store

e8619d3

paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v8.0 labels Jun 10, 2021

paul-tavares self-assigned this Jun 10, 2021

spalger added v8.0.0 and removed v8.0 labels Jun 10, 2021

paul-tavares added 8 commits June 14, 2021 10:17

Generator improvements for how actions are generated for Endpoints

5f94782

Styles for the Endpoint Agent Status components

423d569

Add new EndpointAgentStatus component to the endpoint details

4e5aa55

Fix unit test

9133081

tests for Endpoint Host Isolation Status

dabe222

Tests and Mocks for Endpoint Pending actions API service

75df4a2

adjustments to mocks for pending actions as well as the http mock fac…

1d5522d

…tory

dasansol92 reviewed Jun 15, 2021

View reviewed changes

dasansol92 approved these changes Jun 15, 2021

View reviewed changes

paul-tavares added 5 commits June 15, 2021 09:28

Add HTTP mock for fleet EPM packages (to silence console errors)

b82056a

tests for EndpointAgentStatus component

02e9364

new .updateCommonInfo() method to generator

3bb4597

middleware test for calling pending actions api

ec5d88e

Merge remote-tracking branch 'upstream/master' into task/olm-1246-sho…

9e3734d

…w-isolation-status-on-endpoint-list

paul-tavares marked this pull request as ready for review June 15, 2021 19:29

paul-tavares requested a review from a team as a code owner June 15, 2021 19:29

pzl approved these changes Jun 15, 2021

View reviewed changes

ashokaditya approved these changes Jun 15, 2021

View reviewed changes

x-pack/plugins/security_solution/common/endpoint/index_data.ts Outdated Show resolved Hide resolved

x-pack/plugins/security_solution/common/endpoint/data_generators/fleet_action_generator.ts Outdated Show resolved Hide resolved

code review feedback

1ddcecf

paul-tavares merged commit 1b7a5a9 into elastic:master Jun 16, 2021

paul-tavares deleted the task/olm-1246-show-isolation-status-on-endpoint-list branch June 16, 2021 13:59

kibanamachine mentioned this pull request Jun 16, 2021

[7.x] [Security Solution][Endpoint] Show Endpoint Host Isolation status on endpoint list (#101961) #102348

Merged

ashokaditya added a commit that referenced this pull request Jul 5, 2021

[Security Solution][Endpoint] Mark code for refactor (#104278)

8d84c2f

* mark for refactor refs elastic/security-team/issues/1407 refs /pull/101961/files * update comments review change

madirey pushed a commit to madirey/kibana that referenced this pull request Jul 6, 2021

[Security Solution][Endpoint] Mark code for refactor (elastic#104278)

d44f179

* mark for refactor refs elastic/security-team/issues/1407 refs elastic/pull/101961/files * update comments review change

ashokaditya added a commit that referenced this pull request Jul 7, 2021

[Security Solution][Endpoint] Mark code for refactor (#104278) (#104593)

070edd8

* mark for refactor refs elastic/security-team/issues/1407 refs /pull/101961/files * update comments review change

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Endpoint] Show Endpoint Host Isolation status on endpoint list #101961

[Security Solution][Endpoint] Show Endpoint Host Isolation status on endpoint list #101961

paul-tavares commented Jun 10, 2021 •

edited

Loading

dasansol92 Jun 15, 2021

paul-tavares Jun 15, 2021

dasansol92 Jun 16, 2021

paul-tavares Jun 16, 2021

dasansol92 Jun 16, 2021

dasansol92 left a comment

elasticmachine commented Jun 15, 2021

ashokaditya left a comment

kibanamachine commented Jun 15, 2021

kibanamachine commented Jun 16, 2021

[Security Solution][Endpoint] Show Endpoint Host Isolation status on endpoint list #101961

[Security Solution][Endpoint] Show Endpoint Host Isolation status on endpoint list #101961

Conversation

paul-tavares commented Jun 10, 2021 • edited Loading

Summary

Checklist

dasansol92 Jun 15, 2021

Choose a reason for hiding this comment

paul-tavares Jun 15, 2021

Choose a reason for hiding this comment

dasansol92 Jun 16, 2021

Choose a reason for hiding this comment

paul-tavares Jun 16, 2021

Choose a reason for hiding this comment

dasansol92 Jun 16, 2021

Choose a reason for hiding this comment

dasansol92 left a comment

Choose a reason for hiding this comment

elasticmachine commented Jun 15, 2021

ashokaditya left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 15, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

kibanamachine commented Jun 16, 2021

💚 Backport successful

paul-tavares commented Jun 10, 2021 •

edited

Loading