-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Clusters] Migrate to new page layout #102042
[Remote Clusters] Migrate to new page layout #102042
Conversation
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @sabarasaba! I left a couple minor comments in the code.
I also noticed a few UX discrepancies compared with our other apps. I think this was all pre-existing behavior though, so I can open up a separate issue to address.
- It seemed strange to have the error prompt as well as a toast notification. I think the prompt is sufficient.
- In most of our UIs, we have a doc link to the left of the page header and the action button ("Create a remote cluster") is right-aligned to the search input.
...ugins/remote_clusters/public/application/sections/remote_cluster_edit/remote_cluster_edit.js
Outdated
Show resolved
Hide resolved
...ugins/remote_clusters/public/application/sections/remote_cluster_list/remote_cluster_list.js
Outdated
Show resolved
Hide resolved
...ugins/remote_clusters/public/application/sections/remote_cluster_list/remote_cluster_list.js
Outdated
Show resolved
Hide resolved
@alisonelizabeth Thanks for having a look! The 2 extra changes were small enough that I felt could be included in this PR, lmkwyt |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
👍 Thanks! Changes LGTM. |
* change page templates * Small copy tweaks * Update docs * small CR changes * exit function call if fails * update i18n strings Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* change page templates * Small copy tweaks * Update docs * small CR changes * exit function call if fails * update i18n strings Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* change page templates * Small copy tweaks * Update docs * small CR changes * exit function call if fails * update i18n strings Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This PR migrates
Remote Clusters
to use the new page layout.Related: #100748
Screenshots
List
Create
Edit