Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[User Experience App] Update to make sure env filter is being used #102063

Merged
merged 3 commits into from
Jun 15, 2021
Merged

[User Experience App] Update to make sure env filter is being used #102063

merged 3 commits into from
Jun 15, 2021

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jun 14, 2021 •
edited
Loading

Summary

Fix: #102069

Made sure environment filter is being passed to ES query as it's propagated from UI as uiFilters.

Updated unit test to cover this use case.

image

@shahzad31 shahzad31 marked this pull request as ready for review June 14, 2021 13:49
@shahzad31 shahzad31 requested review from a team as code owners June 14, 2021 13:49
@shahzad31 shahzad31 self-assigned this Jun 14, 2021
@shahzad31 shahzad31 added release_note:fix v7.13.3 v7.14.0 v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability labels Jun 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jun 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@shahzad31 shahzad31 requested a review from sorenlouv June 14, 2021 17:32
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shahzad31

dominiqueclarke
dominiqueclarke approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sorenlouv
sorenlouv approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shahzad31 shahzad31 added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 15, 2021
@shahzad31 shahzad31 merged commit 7390d6a into elastic:master Jun 15, 2021
@shahzad31 shahzad31 deleted the env-filter-fix branch June 15, 2021 10:41
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 15, 2021
@shahzad31 @kibanamachine
[User Experience App] Update to make sure env filter is being used (e…
0cfef1a 
…lastic#102063)
@kibanamachine kibanamachine mentioned this pull request Jun 15, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 15, 2021
@shahzad31 @kibanamachine
[User Experience App] Update to make sure env filter is being used (e…
b26927f 
…lastic#102063)
@kibanamachine kibanamachine mentioned this pull request Jun 15, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 15, 2021
@kibanamachine @shahzad31
[User Experience App] Update to make sure env filter is being used (#…
75c35e8 
…102063) (#102184)

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
kibanamachine added a commit that referenced this pull request Jun 15, 2021
@kibanamachine @shahzad31
[User Experience App] Update to make sure env filter is being used (#…
2cb387b 
…102063) (#102185)

Co-authored-by: Shahzad <shahzad.muhammad@elastic.co>
cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jun 15, 2021
@shahzad31
[User Experience App] Update to make sure env filter is being used (e…
14fc3b1 
…lastic#102063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees

@shahzad31 shahzad31

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:fix Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.13.3 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[User Experience App] Environment filter is broken
5 participants
@shahzad31 @elasticmachine @kibanamachine @sorenlouv @dominiqueclarke