Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix time shift usability issues #102709

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Jun 21, 2021

Fixes #102116
Fixes #102405

This PR fixes a few usability issues with time shift in Lens:

I'm not sure about the placeholder change. We thought about something like "Enter a time shift. Type to specify custom values (e.g. 8w)" but the space is way to tight for that. The best i could do is "Type custom values (e.g. 8w)", but even that won't be visible on all screen widths:
Screenshot 2021-06-21 at 11 22 01
Screenshot 2021-06-21 at 11 22 05

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 21, 2021
@flash1293 flash1293 marked this pull request as ready for review June 21, 2021 12:04
@flash1293 flash1293 requested a review from a team June 21, 2021 12:04
@flash1293 flash1293 requested a review from a team as a code owner June 21, 2021 12:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the space issue, you could use the helpText property instead of placeholder. What do you think about explaining only the custom option as part of helpText?

Screen Shot 2021-06-21 at 2 56 42 PM

@ghudgins
Copy link

What do you think about explaining only the custom option as part of helpText?

@wylieconlon the problem with this is the dropdown covers the helper text and, as soon as you click "time shift" in the popover, we move the user into the dropdown for fewer clicks & what I assume are good accessibility reasons.

I think Type custom value gets the important part across (type) even if it gets clipped. Not sure about other languages of course. But either way the placeholder seems better than what it is now which is redundant Time shift

image

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293
Copy link
Contributor Author

flash1293 commented Jun 22, 2021

@wylieconlon @ghudgins If you are happy with this solution, I am happy - I think it's better than the current placeholder and we can give it a shot and see whether this problem is still happening.

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally 👍

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppServices regular expression change LGTM.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +59.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 831.2KB 831.2KB +3.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 498df21 into elastic:master Jun 23, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 23, 2021
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 23, 2021
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
7 participants