[Maps] fix save to maps for by_value map embeddables

[nreese]

Fixes #99560

To view problem

1. install sample data set
2. create dashboard
3. create map from dashboard and return to dashboard
4. in the dashboard map panel open list, click "Edit map".
5. Click "save in maps". Unselect add to dashboard. Click save
6. notice that the map was not saved or converted from by_value to by_reference.

This PR resolves the problem by properly passing addToLibrary flag to savedMap.save

[elasticmachine]

Pinging @elastic/kibana-gis (Team:Geo)

[ThomThomson]

Tested this in 7.13.2 and did see the issue. Tested it again with this fix, and the map is added to the library / the maps app.

This addresses the last point in #99560, which is the most major discrepancy. Thanks for tackling this!

I wonder if we should add an additional functional test to https://github.com/elastic/kibana/blob/master/x-pack/test/functional/apps/dashboard/dashboard_maps_by_value.ts to ensure that this sort of thing doesn't happen again.

[nreese]

This addresses the last point in #99560, which is the most major discrepancy. Thanks for tackling this!

Thanks for pointing out #99560. I had forgettn about this issue but ya, this explains all of what is going on.

I have pushed a change to address the point "When clicking save to library or save to maps when editing a panel by value, Visualize and Lens, show the save as dialog with the option to update Panel on dashboard. In Maps, the option reads Add to dashboard after saving". Now the dialog will also say "update Panel on dashboard" in maps.

All of #99560 should be addressed now. I will update the PR description to state that this PR fixes #99560

[ThomThomson]

That's awesome! Thanks again!

[nreese]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: b1b77d6
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
maps	3.1MB	3.1MB	+415.0B

History

• 💚 Build #133360 succeeded e8417be
• 💚 Build #133260 succeeded 1b079fa

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kindsun]

lgtm! Thanks for fixing this 🙇

• code review
• tested locally in chrome

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.