Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Fix synthetics integration flaky tests #103691

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Jun 29, 2021

Summary

Relates to #102004
Relates to #103390
Relates to #102122

This PR resolves flaky tests by increasing the timeout for finding values.

Previously, I actually set the timeout for some values to 5000 ms, but the default when unspecified is actually 10000 so I inadvertently reduced the time. I have removed this override in favor of the default.

This PR has been run through flaky test runner

@dominiqueclarke dominiqueclarke added failed-test A test failure on a tracked branch, potentially flaky-test v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 29, 2021
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner June 29, 2021 15:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@dominiqueclarke dominiqueclarke force-pushed the fix/102004-uptime-synthetics-integration-fix-flaky-tests branch from 9f8dbb2 to 5634843 Compare June 29, 2021 15:31
@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@spalger spalger added v7.15.0 and removed v7.14.0 labels Jun 30, 2021
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit 17443d0 into elastic:master Jul 1, 2021
@dominiqueclarke dominiqueclarke deleted the fix/102004-uptime-synthetics-integration-fix-flaky-tests branch July 1, 2021 19:59
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 1, 2021
* focus uptime synthetics integration tests

* unfocus tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.14

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 1, 2021
* focus uptime synthetics integration tests

* unfocus tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
madirey pushed a commit to madirey/kibana that referenced this pull request Jul 6, 2021
* focus uptime synthetics integration tests

* unfocus tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@spalger spalger added the v7.15.0 label Jul 7, 2021
spalger pushed a commit to spalger/kibana that referenced this pull request Jul 7, 2021
* focus uptime synthetics integration tests

* unfocus tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Jul 7, 2021
* focus uptime synthetics integration tests

* unfocus tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Dominique Clarke <doclarke71@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed failed-test A test failure on a tracked branch, potentially flaky-test release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants