Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Fix Cluster Listing view #103718

Merged
merged 3 commits into from
Jun 30, 2021
Merged

[Monitoring] Fix Cluster Listing view #103718

merged 3 commits into from
Jun 30, 2021

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Jun 29, 2021 •
edited
Loading

Summary

Resolves #102090
When there is more than one cluster and no nodes exist on the cluster, the page does not load. A good place to test this is using Edge and trying to access Stack Monitoring. The view should look like this:

Screen Shot 2021-06-29 at 12 52 19 PM

@neptunian neptunian self-assigned this Jun 29, 2021
@neptunian neptunian added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.14.0 v8.0.0 release_note:fix labels Jun 29, 2021
@neptunian neptunian marked this pull request as ready for review June 29, 2021 17:12
@neptunian neptunian requested a review from a team June 29, 2021 17:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@neptunian neptunian added Feature:Stack Monitoring bug Fixes for quality problems that affect the customer experience labels Jun 29, 2021
jasonrhodes
jasonrhodes approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Screen Shot 2021-06-29 at 1 58 28 PM

@neptunian can you log a ticket that references this one, for us to investigate why this return value seems to be slightly malformed in the first place?

@neptunian neptunian mentioned this pull request Jun 29, 2021
Open
@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

15 similar comments
@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

2 similar comments
@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

@neptunian
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@neptunian neptunian merged commit 0de3df5 into elastic:master Jun 30, 2021
neptunian added a commit to neptunian/kibana that referenced this pull request Jun 30, 2021
@neptunian @kibanamachine
[Monitoring] Fix Cluster Listing view (elastic#103718)
32dd5c9 
* check for number of nodes

* remove console

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@neptunian neptunian mentioned this pull request Jun 30, 2021
Merged
neptunian added a commit that referenced this pull request Jun 30, 2021
@neptunian @kibanamachine
[Monitoring] Fix Cluster Listing view (#103718) (#103806)
f50f676 
* check for number of nodes

* remove console

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 737.8KB 737.8KB +25.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

@neptunian neptunian mentioned this pull request Jul 6, 2021
Closed
35 tasks
@matschaffer matschaffer mentioned this pull request Aug 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonrhodes jasonrhodes jasonrhodes approved these changes

Assignees

@neptunian neptunian

Labels
bug Fixes for quality problems that affect the customer experience Feature:Stack Monitoring release_note:fix Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Monitoring] Cluster listing doesn't load when nodes don't exist
4 participants
@neptunian @elasticmachine @kibanamachine @jasonrhodes