[Fleet] Add back minimum value for unenroll timeout and add validation messages #103898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
jen-huang
added
release_note:skip
kpollich
approved these changes
Jun 30, 2021
jen-huang
added
the
auto-backport
💚 Build SucceededMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @jen-huang |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
jen-huang
added
auto-backport
💔 Backport failed
To backport manually run: |
kibanamachine
added a commit
that referenced
this pull request
Jun 30, 2021
jen-huang
added a commit
that referenced
this pull request
Jun 30, 2021
madirey
pushed a commit
to madirey/kibana
that referenced
this pull request
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #103790. I missed that negative values became allowed after those changes, so this PR restores a minimum value of zero, and also adds an error message if the user manually inputs a value below zero: