[ML] Add integration tests for trained_models API
#104819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
15 tasks
| await Promise.all(testModelIds.map((modelId) => ml.api.deleteIngestPipeline(modelId))); | ||
| }); | ||
|
|
||
| it('returns all trained models with associated pipelined', async () => { |
There was a problem hiding this comment.
Typo - should just be pipelines
qn895
reviewed
Jul 8, 2021
qn895
reviewed
Jul 8, 2021
qn895
reviewed
Jul 9, 2021
x-pack/test/api_integration/apis/ml/trained_models/get_model_pipelines.ts
Outdated
Show resolved
Hide resolved
qn895
reviewed
Jul 9, 2021
x-pack/test/api_integration/apis/ml/trained_models/get_model_stats.ts
Outdated
Show resolved
Hide resolved
qn895
reviewed
Jul 9, 2021
x-pack/test/api_integration/apis/ml/trained_models/get_models.ts
Outdated
Show resolved
Hide resolved
|
Tests LGTM 🎉 Just left a few small comments |
qn895
approved these changes
Jul 9, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @darnautov |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2021
* [ML] api integration tests for get trained models endpoint * [ML] delete ingest pipelines after tests execution * [ML] deleteIngestPipeline method * [ML] test for unauthorized user * [ML] tests for model stats * [ML] delete trained model tests * [ML] fix typo * [ML] fix expect package path * [ML] get model pipelines tests * [ML] test for aliases * [ML] add tests for a 404 response * [ML] fix typo * [ML] fix typo
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 9, 2021
* [ML] api integration tests for get trained models endpoint * [ML] delete ingest pipelines after tests execution * [ML] deleteIngestPipeline method * [ML] test for unauthorized user * [ML] tests for model stats * [ML] delete trained model tests * [ML] fix typo * [ML] fix expect package path * [ML] get model pipelines tests * [ML] test for aliases * [ML] add tests for a 404 response * [ML] fix typo * [ML] fix typo
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2021
* [ML] api integration tests for get trained models endpoint * [ML] delete ingest pipelines after tests execution * [ML] deleteIngestPipeline method * [ML] test for unauthorized user * [ML] tests for model stats * [ML] delete trained model tests * [ML] fix typo * [ML] fix expect package path * [ML] get model pipelines tests * [ML] test for aliases * [ML] add tests for a 404 response * [ML] fix typo * [ML] fix typo Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jul 9, 2021
* [ML] api integration tests for get trained models endpoint * [ML] delete ingest pipelines after tests execution * [ML] deleteIngestPipeline method * [ML] test for unauthorized user * [ML] tests for model stats * [ML] delete trained model tests * [ML] fix typo * [ML] fix expect package path * [ML] get model pipelines tests * [ML] test for aliases * [ML] add tests for a 404 response * [ML] fix typo * [ML] fix typo Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
90 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #97982
Adds integration tests for Kibana's
trained_modelsAPI endpoints.Checklist