Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Reporting] Clean up types for internal APIs needed for UI (#105508) #105702

Merged
merged 1 commit into from
Jul 15, 2021
Merged

[7.x] [Reporting] Clean up types for internal APIs needed for UI (#105508) #105702

merged 1 commit into from
Jul 15, 2021

Conversation

tsullivan
Copy link
Member

Backports the following commits to 7.x:

@tsullivan @jloleysens @dokmic
[Reporting] Clean up types for internal APIs needed for UI (elastic#1…
35fc0bf 
…05508)

* [Reporting] Refactor types for API response data

* fix api test

* Update x-pack/plugins/reporting/common/types.ts

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>

* more verbose comments

* set comments in interface type definition

* Update x-pack/plugins/reporting/common/types.ts

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

* more strict

* Update x-pack/plugins/reporting/public/management/report_info_button.tsx

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

* Update x-pack/plugins/reporting/public/management/report_info_button.tsx

Co-authored-by: Michael Dokolin <dokmic@gmail.com>

* fix suggestion

* fix accidental declaration of interface methods as function properties

* fix info panel

Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com>
Co-authored-by: Michael Dokolin <dokmic@gmail.com>
@tsullivan tsullivan enabled auto-merge (squash) July 15, 2021 00:50
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
reporting 59 60 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 69.9KB 70.1KB +220.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
reporting 18 14 -4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 56.5KB 58.8KB +2.3KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan merged commit 1ce67c9 into elastic:7.x Jul 15, 2021
@tsullivan tsullivan deleted the backport/7.x/pr-105508 branch July 20, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsullivan @kibanamachine