Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix edit integration breadcrumb (#106252) #106409

Merged

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Jul 21, 2021

Summary

fixes: #106252

When navigating to edit integration via "Integrations -> manage -> (choose any) -> policies -> (click integration name)" the breadcrumb was broken.

This was due to us using the policy breadcrumb hook not the integrations, this may have been broken when we moved integrations to a separate app.

Screenshot 2021-07-21 at 14 05 31

@hop-dev hop-dev added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 21, 2021
@hop-dev hop-dev self-assigned this Jul 21, 2021
@hop-dev hop-dev added the release_note:skip Skip the PR/issue when compiling release notes label Jul 21, 2021
@hop-dev hop-dev marked this pull request as ready for review July 21, 2021 14:03
@hop-dev hop-dev requested a review from a team as a code owner July 21, 2021 14:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@hop-dev hop-dev enabled auto-merge (squash) July 21, 2021 14:44
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 734.0KB 734.1KB +91.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @hop-dev

@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.14
7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 21, 2021
Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>
kibanamachine added a commit that referenced this pull request Jul 21, 2021
Co-authored-by: Mark Hopkin <mark.hopkin@elastic.co>
@hop-dev hop-dev deleted the bugfix/106252-edit-integration-breadcrumb branch July 22, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.14.0 v7.15.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Kibana Bread crumb is displayed on the integration tab while editing integration.
4 participants