Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable reporting for all "oss: false" integration tests #107360

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Disable reporting for all "oss: false" integration tests #107360

merged 2 commits into from
Aug 2, 2021

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Aug 2, 2021

Summary

Closes #96895
Considering that we should run tests against the default dist that includes x-pack folder, I'd say that the right solution is to disable the loading Chromium binary on CI #102919

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 2, 2021
@mshustov mshustov requested a review from a team as a code owner August 2, 2021 07:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

afharo
afharo approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshustov mshustov merged commit 3bd9ff3 into elastic:master Aug 2, 2021
@mshustov mshustov deleted the issue-96895-unskip branch August 2, 2021 15:44
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 2, 2021
@mshustov @kibanamachine
Disable reporting for all "oss: false" integration tests (elastic#107360
863d5db 
)

* disable reporting for all the integration test with oss:false

* unskip test
@kibanamachine kibanamachine mentioned this pull request Aug 2, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 2, 2021
@kibanamachine @mshustov
Disable reporting for all "oss: false" integration tests (#107360) (#…
cda7cfe 
…107409)

* disable reporting for all the integration test with oss:false

* unskip test

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
streamich pushed a commit to vadimkibana/kibana that referenced this pull request Aug 8, 2021
@mshustov @vadimkibana
Disable reporting for all "oss: false" integration tests (elastic#107360
635c821 
)

* disable reporting for all the integration test with oss:false

* unskip test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@mshustov @elasticmachine @kibanamachine @afharo