[Security Solution] Fix expand hover action in data grid #108616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
v8.0.0
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
48 tasks
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
angorayc
added
the
auto-backport
machadoum
approved these changes
Aug 16, 2021
| const rowData = rowIndex < data.length ? data[rowIndex].data : null; | ||
| const header = columnHeaders.find((h) => h.id === columnId); | ||
| const eventId = rowIndex < data.length ? data[rowIndex]._id : null; | ||
|
|
||
| addBuildingBlockStyle(data[rowIndex].ecs, theme, setCellProps); | ||
| useEffect(() => { |
| }, | ||
| [columnHeaders, data, id, renderCellValue, tabType, theme, browserFields, rowRenderers] | ||
| ); | ||
| }) as React.ReactElement; |
There was a problem hiding this comment.
I think that this type coercion is misleading. But I don't know a good way of converting a ReacElement to a ReactNode. Ideally, EuiDataGrid renderCellValue prop should have the same type as t-grid renderCellValue. But that would be a massive change for this PR.
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 16, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to Fix expand hover action in data grid.
Before:
After fixed:
