Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [RAC][Rule Registry] Improve RuleDataService API and index bootstrapping implementation (#108115) #108638

Merged
merged 1 commit into from
Aug 15, 2021

Commits on Aug 15, 2021

  1. [RAC][Rule Registry] Improve RuleDataService API and index bootstrapp…

    …ing implementation (elastic#108115)
    
    **Addresses:** elastic#106421, elastic#106428, elastic#102089, elastic#106433
    
    ## Summary
    
    This PR focuses on consolidation of indexing implementations in `rule_registry` (elastic#101016). It addresses some of the sub-tasks of the parent ticket.
    
    - [x] Encapsulate index bootstrapping logic in a new improved API exposed by `RuleDataService`.
    - [x] Enforce allowed values for the `datasetSuffix` on the API level.
    - [x] Migrate plugins using the existing `RuleDataService` API to the improved one.
    - [x] Make sure index names comply with design architecture.
        - elastic#102089
    - [x] Improve the API of `RuleDataClient`.
    - [x] Enhance index bootstrapping: support custom ILM policy per index (`{registrationContext}.{datasetSuffix}`).
    - [x] Enhance index bootstrapping: create index template per namespace and support rollovers properly
        - based on elastic#107700
    - [x] Enhance index bootstrapping: support secondary aliases
        - based on elastic#107700
    - [x] Remove `EventLogService` implementation
        - elastic#106433
    
    This will be addressed in follow-up PRs:
    
    - [ ] Enhance index bootstrapping: implement suggestions for backwards compatibility (naming scheme for alias and backing indices; versioning).
    - [ ] Enhance index bootstrapping: implement upgrades of existing index templates.
    - [ ] Make index bootstrapping logic more robust. This _is partially addressed_ in this PR, but more improvements are needed.
    - [ ] Change the way index prefix works.
    - [ ] Add support for optional TS schema (static typing).
    - [ ] Update `README` in `rule_registry`.
    
    ### Checklist
    
    - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials
    - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
    banderror authored and kibanamachine committed Aug 15, 2021
    Configuration menu
    Copy the full SHA
    9be3d4d View commit details
    Browse the repository at this point in the history