[RAC] Replace usages of kibana.alert.status: open with active

packages/kbn-rule-data-utils/src/alerts_as_data_rbac.ts

@@ -26,6 +26,11 @@ export const AlertConsumers = {
 export type AlertConsumers = typeof AlertConsumers[keyof typeof AlertConsumers];
 export type STATUS_VALUES = 'open' | 'acknowledged' | 'closed' | 'in-progress'; // TODO: remove 'in-progress' after migration to 'acknowledged'
 
+export const ALERT_STATUS_ACTIVE = 'active';
+export const ALERT_STATUS_RECOVERED = 'recovered';
+
+export type AlertStatus = typeof ALERT_STATUS_ACTIVE | typeof ALERT_STATUS_RECOVERED;
+
 export const mapConsumerToIndexName: Record<AlertConsumers, string | string[]> = {
   apm: '.alerts-observability-apm',
   logs: '.alerts-observability.logs',

x-pack/plugins/apm/public/components/shared/charts/helper/get_alert_annotations.test.tsx

@@ -16,6 +16,7 @@ import {
   ALERT_SEVERITY,
   ALERT_START,
   ALERT_STATUS,
+  ALERT_STATUS_ACTIVE,
   ALERT_UUID,
   SPACE_IDS,
   ALERT_RULE_UUID,
@@ -43,7 +44,7 @@ const alert: Alert = {
   'service.name': ['frontend-rum'],
   [ALERT_RULE_NAME]: ['Latency threshold | frontend-rum'],
   [ALERT_DURATION]: [62879000],
-  [ALERT_STATUS]: ['open'],
+  [ALERT_STATUS]: [ALERT_STATUS_ACTIVE],
   [SPACE_IDS]: ['myfakespaceid'],
   tags: ['apm', 'service.name:frontend-rum'],
   'transaction.type': ['page-load'],

x-pack/plugins/apm/public/components/shared/charts/latency_chart/latency_chart.stories.tsx

@@ -14,6 +14,7 @@ import {
   ALERT_SEVERITY,
   ALERT_START,
   ALERT_STATUS,
+  ALERT_STATUS_ACTIVE,
   ALERT_UUID,
   ALERT_RULE_UUID,
   ALERT_RULE_NAME,
@@ -133,7 +134,7 @@ Example.args = {
         'service.name': ['frontend-rum'],
         [ALERT_RULE_NAME]: ['Latency threshold | frontend-rum'],
         [ALERT_DURATION]: [10000000000],
-        [ALERT_STATUS]: ['open'],
+        [ALERT_STATUS]: [ALERT_STATUS_ACTIVE],
         tags: ['apm', 'service.name:frontend-rum'],
         'transaction.type': ['page-load'],
         [ALERT_RULE_PRODUCER]: ['apm'],
@@ -154,7 +155,7 @@ Example.args = {
         'service.name': ['frontend-rum'],
         [ALERT_RULE_NAME]: ['Latency threshold | frontend-rum'],
         [ALERT_DURATION]: [10000000000],
-        [ALERT_STATUS]: ['open'],
+        [ALERT_STATUS]: [ALERT_STATUS_ACTIVE],
         tags: ['apm', 'service.name:frontend-rum'],
         'transaction.type': ['page-load'],
         [ALERT_RULE_PRODUCER]: ['apm'],
@@ -176,7 +177,7 @@ Example.args = {
         'service.name': ['frontend-rum'],
         [ALERT_RULE_NAME]: ['Latency threshold | frontend-rum'],
         [ALERT_DURATION]: [1000000000],
-        [ALERT_STATUS]: ['open'],
+        [ALERT_STATUS]: [ALERT_STATUS_ACTIVE],
         tags: ['apm', 'service.name:frontend-rum'],
         'transaction.type': ['page-load'],
         [ALERT_RULE_PRODUCER]: ['apm'],

x-pack/plugins/observability/public/pages/alerts/example_data.ts

@@ -13,6 +13,8 @@ import {
   ALERT_RULE_TYPE_ID,
   ALERT_START,
   ALERT_STATUS,
+  ALERT_STATUS_ACTIVE,
+  ALERT_STATUS_RECOVERED,
   ALERT_UUID,
   ALERT_RULE_UUID,
   ALERT_RULE_NAME,
@@ -26,7 +28,7 @@ export const apmAlertResponseExample = [
     'service.name': ['opbeans-java'],
     [ALERT_RULE_NAME]: ['Error count threshold | opbeans-java (smith test)'],
     [ALERT_DURATION]: [180057000],
-    [ALERT_STATUS]: ['open'],
+    [ALERT_STATUS]: [ALERT_STATUS_ACTIVE],
     [ALERT_SEVERITY]: ['warning'],
     tags: ['apm', 'service.name:opbeans-java'],
     [ALERT_UUID]: ['0175ec0a-a3b1-4d41-b557-e21c2d024352'],
@@ -47,7 +49,7 @@ export const apmAlertResponseExample = [
     [ALERT_RULE_NAME]: ['Error count threshold | opbeans-java (smith test)'],
     [ALERT_DURATION]: [2419005000],
     [ALERT_END]: ['2021-04-12T13:49:49.446Z'],
-    [ALERT_STATUS]: ['closed'],
+    [ALERT_STATUS]: [ALERT_STATUS_RECOVERED],
     tags: ['apm', 'service.name:opbeans-java'],
     [ALERT_UUID]: ['32b940e1-3809-4c12-8eee-f027cbb385e2'],
     [ALERT_RULE_UUID]: ['474920d0-93e9-11eb-ac86-0b455460de81'],

x-pack/plugins/rule_registry/server/alert_data_client/tests/bulk_update.test.ts

@@ -8,6 +8,7 @@
 import {
   ALERT_RULE_CONSUMER,
   ALERT_STATUS,
+  ALERT_STATUS_ACTIVE,
   SPACE_IDS,
   ALERT_RULE_TYPE_ID,
 } from '@kbn/rule-data-utils';
@@ -90,7 +91,7 @@ describe('bulkUpdate()', () => {
                   _source: {
                     [ALERT_RULE_TYPE_ID]: 'apm.error_rate',
                     [ALERT_RULE_CONSUMER]: 'apm',
-                    [ALERT_STATUS]: 'open',
+                    [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
                     [SPACE_IDS]: [DEFAULT_SPACE],
                   },
                 },
@@ -147,7 +148,7 @@ describe('bulkUpdate()', () => {
                   _source: {
                     [ALERT_RULE_TYPE_ID]: fakeRuleTypeId,
                     [ALERT_RULE_CONSUMER]: 'apm',
-                    [ALERT_STATUS]: 'open',
+                    [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
                     [SPACE_IDS]: [DEFAULT_SPACE],
                   },
                 },
@@ -193,7 +194,7 @@ describe('bulkUpdate()', () => {
                   _source: {
                     [ALERT_RULE_TYPE_ID]: 'apm.error_rate',
                     [ALERT_RULE_CONSUMER]: 'apm',
-                    [ALERT_STATUS]: 'open',
+                    [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
                     [SPACE_IDS]: [DEFAULT_SPACE],
                   },
                 },
@@ -203,7 +204,7 @@ describe('bulkUpdate()', () => {
                   _source: {
                     [ALERT_RULE_TYPE_ID]: fakeRuleTypeId,
                     [ALERT_RULE_CONSUMER]: 'apm',
-                    [ALERT_STATUS]: 'open',
+                    [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
                     [SPACE_IDS]: [DEFAULT_SPACE],
                   },
                 },
@@ -280,7 +281,7 @@ describe('bulkUpdate()', () => {
                     _source: {
                       [ALERT_RULE_TYPE_ID]: 'apm.error_rate',
                       [ALERT_RULE_CONSUMER]: 'apm',
-                      [ALERT_STATUS]: 'open',
+                      [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
                       [SPACE_IDS]: [DEFAULT_SPACE],
                     },
                   },
@@ -300,7 +301,7 @@ describe('bulkUpdate()', () => {
 
         await alertsClient.bulkUpdate({
           ids: undefined,
-          query: `${ALERT_STATUS}: open`,
+          query: `${ALERT_STATUS}: ${ALERT_STATUS_ACTIVE}`,
           index: indexName,
           status: 'closed',
         });
@@ -340,7 +341,7 @@ describe('bulkUpdate()', () => {
                     _source: {
                       [ALERT_RULE_TYPE_ID]: fakeRuleTypeId,
                       [ALERT_RULE_CONSUMER]: 'apm',
-                      [ALERT_STATUS]: 'open',
+                      [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
                       [SPACE_IDS]: [DEFAULT_SPACE],
                     },
                   },
@@ -352,13 +353,13 @@ describe('bulkUpdate()', () => {
         await expect(
           alertsClient.bulkUpdate({
             ids: undefined,
-            query: `${ALERT_STATUS}: open`,
+            query: `${ALERT_STATUS}: ${ALERT_STATUS_ACTIVE}`,
             index: indexName,
             status: 'closed',
           })
         ).rejects.toThrowErrorMatchingInlineSnapshot(`
-                "queryAndAuditAllAlerts threw an error: Unable to retrieve alerts with query \\"kibana.alert.status: open\\" and operation update 
-                 Error: Unable to retrieve alert details for alert with id of \\"null\\" or with query \\"kibana.alert.status: open\\" and operation update 
+                "queryAndAuditAllAlerts threw an error: Unable to retrieve alerts with query \\"kibana.alert.status: active\\" and operation update 
+                 Error: Unable to retrieve alert details for alert with id of \\"null\\" or with query \\"kibana.alert.status: active\\" and operation update 
                 Error: Error: Unauthorized for fake.rule and apm"
               `);
 
@@ -401,7 +402,7 @@ describe('bulkUpdate()', () => {
                     _source: {
                       [ALERT_RULE_TYPE_ID]: 'apm.error_rate',
                       [ALERT_RULE_CONSUMER]: 'apm',
-                      [ALERT_STATUS]: 'open',
+                      [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
                       [SPACE_IDS]: [DEFAULT_SPACE],
                     },
                   },
@@ -411,7 +412,7 @@ describe('bulkUpdate()', () => {
                     _source: {
                       [ALERT_RULE_TYPE_ID]: fakeRuleTypeId,
                       [ALERT_RULE_CONSUMER]: 'apm',
-                      [ALERT_STATUS]: 'open',
+                      [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
                       [SPACE_IDS]: [DEFAULT_SPACE],
                     },
                   },
@@ -423,13 +424,13 @@ describe('bulkUpdate()', () => {
         await expect(
           alertsClient.bulkUpdate({
             ids: undefined,
-            query: `${ALERT_STATUS}: open`,
+            query: `${ALERT_STATUS}: ${ALERT_STATUS_ACTIVE}`,
             index: indexName,
             status: 'closed',
           })
         ).rejects.toThrowErrorMatchingInlineSnapshot(`
-                "queryAndAuditAllAlerts threw an error: Unable to retrieve alerts with query \\"kibana.alert.status: open\\" and operation update 
-                 Error: Unable to retrieve alert details for alert with id of \\"null\\" or with query \\"kibana.alert.status: open\\" and operation update 
+                "queryAndAuditAllAlerts threw an error: Unable to retrieve alerts with query \\"kibana.alert.status: active\\" and operation update 
+                 Error: Unable to retrieve alert details for alert with id of \\"null\\" or with query \\"kibana.alert.status: active\\" and operation update 
                 Error: Error: Unauthorized for fake.rule and apm"
               `);
 

x-pack/plugins/rule_registry/server/alert_data_client/tests/get.test.ts

@@ -8,6 +8,7 @@
 import {
   ALERT_RULE_CONSUMER,
   ALERT_STATUS,
+  ALERT_STATUS_ACTIVE,
   SPACE_IDS,
   ALERT_RULE_TYPE_ID,
 } from '@kbn/rule-data-utils';
@@ -100,7 +101,7 @@ describe('get()', () => {
                   [ALERT_RULE_TYPE_ID]: 'apm.error_rate',
                   message: 'hello world 1',
                   [ALERT_RULE_CONSUMER]: 'apm',
-                  [ALERT_STATUS]: 'open',
+                  [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
                   [SPACE_IDS]: ['test_default_space_id'],
                 },
               },
@@ -114,7 +115,7 @@ describe('get()', () => {
       Object {
         "kibana.alert.rule.consumer": "apm",
         "kibana.alert.rule.rule_type_id": "apm.error_rate",
-        "kibana.alert.status": "open",
+        "kibana.alert.status": "active",
         "kibana.space_ids": Array [
           "test_default_space_id",
         ],
@@ -209,7 +210,7 @@ describe('get()', () => {
                   [ALERT_RULE_TYPE_ID]: 'apm.error_rate',
                   message: 'hello world 1',
                   [ALERT_RULE_CONSUMER]: 'apm',
-                  [ALERT_STATUS]: 'open',
+                  [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
                   [SPACE_IDS]: ['test_default_space_id'],
                 },
               },
@@ -259,7 +260,7 @@ describe('get()', () => {
                 _source: {
                   [ALERT_RULE_TYPE_ID]: fakeRuleTypeId,
                   [ALERT_RULE_CONSUMER]: 'apm',
-                  [ALERT_STATUS]: 'open',
+                  [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
                   [SPACE_IDS]: [DEFAULT_SPACE],
                 },
               },
@@ -332,7 +333,7 @@ describe('get()', () => {
                     [ALERT_RULE_TYPE_ID]: 'apm.error_rate',
                     message: 'hello world 1',
                     [ALERT_RULE_CONSUMER]: 'apm',
-                    [ALERT_STATUS]: 'open',
+                    [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
                     [SPACE_IDS]: ['test_default_space_id'],
                   },
                 },
@@ -354,7 +355,7 @@ describe('get()', () => {
         Object {
           "kibana.alert.rule.consumer": "apm",
           "kibana.alert.rule.rule_type_id": "apm.error_rate",
-          "kibana.alert.status": "open",
+          "kibana.alert.status": "active",
           "kibana.space_ids": Array [
             "test_default_space_id",
           ],

x-pack/plugins/rule_registry/server/routes/get_alert_by_id.test.ts

@@ -9,6 +9,7 @@ import {
   ALERT_RULE_CONSUMER,
   ALERT_RULE_RISK_SCORE,
   ALERT_STATUS,
+  ALERT_STATUS_ACTIVE,
   ECS_VERSION,
   ALERT_RULE_TYPE_ID,
   SPACE_IDS,
@@ -29,7 +30,7 @@ const getMockAlert = (): ParsedTechnicalFields => ({
   [VERSION]: '7.13.0',
   [ALERT_RULE_TYPE_ID]: 'apm.error_rate',
   [ALERT_RULE_CONSUMER]: 'apm',
-  [ALERT_STATUS]: 'open',
+  [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
   [ALERT_RULE_RISK_SCORE]: 20,
   [SPACE_IDS]: ['fake-space-id'],
 });

x-pack/plugins/security_solution/public/detections/components/alerts_table/default_config.tsx

@@ -10,7 +10,7 @@ import {
   ALERT_ID,
   ALERT_RULE_PRODUCER,
   ALERT_START,
-  ALERT_STATUS,
+  ALERT_WORKFLOW_STATUS,
   ALERT_UUID,
   ALERT_RULE_UUID,
   ALERT_RULE_NAME,
@@ -146,14 +146,14 @@ export const buildAlertStatusFilterRuleRegistry = (status: Status): Filter[] =>
       negate: false,
       disabled: false,
       type: 'phrase',
-      key: ALERT_STATUS,
+      key: ALERT_WORKFLOW_STATUS,
       params: {
         query: status,
       },
     },
     query: {
       term: {
-        [ALERT_STATUS]: status,
+        [ALERT_WORKFLOW_STATUS]: status,
       },
     },
   },
@@ -186,7 +186,7 @@ export const requiredFieldMappingsForActionsRuleRegistry = {
   'alert.start': ALERT_START,
   'alert.uuid': ALERT_UUID,
   'event.action': 'event.action',
-  'alert.status': ALERT_STATUS,
+  'alert.workflow_status': ALERT_WORKFLOW_STATUS,
   'alert.duration.us': ALERT_DURATION,
   'rule.uuid': ALERT_RULE_UUID,
   'rule.name': ALERT_RULE_NAME,

x-pack/plugins/security_solution/server/lib/detection_engine/rule_types/factories/utils/build_alert.test.ts

@@ -10,6 +10,7 @@ import {
   ALERT_RULE_CONSUMER,
   ALERT_RULE_NAMESPACE,
   ALERT_STATUS,
+  ALERT_STATUS_ACTIVE,
   ALERT_WORKFLOW_STATUS,
   SPACE_IDS,
 } from '@kbn/rule-data-utils';
@@ -71,7 +72,7 @@ describe('buildAlert', () => {
       ],
       [ALERT_ORIGINAL_TIME]: '2020-04-20T21:27:45.000Z',
       [ALERT_REASON]: 'alert reasonable reason',
-      [ALERT_STATUS]: 'open',
+      [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
       [ALERT_WORKFLOW_STATUS]: 'open',
       ...flattenWithPrefix(ALERT_RULE_NAMESPACE, {
         author: [],
@@ -148,7 +149,7 @@ describe('buildAlert', () => {
         module: 'system',
       },
       [ALERT_REASON]: 'alert reasonable reason',
-      [ALERT_STATUS]: 'open',
+      [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
       [ALERT_WORKFLOW_STATUS]: 'open',
       ...flattenWithPrefix(ALERT_RULE_NAMESPACE, {
         author: [],

x-pack/plugins/security_solution/server/lib/detection_engine/rule_types/factories/utils/build_alert.ts

@@ -10,6 +10,7 @@ import {
   ALERT_RULE_CONSUMER,
   ALERT_RULE_NAMESPACE,
   ALERT_STATUS,
+  ALERT_STATUS_ACTIVE,
   ALERT_WORKFLOW_STATUS,
   SPACE_IDS,
 } from '@kbn/rule-data-utils';
@@ -109,7 +110,7 @@ export const buildAlert = (
     [ALERT_RULE_CONSUMER]: SERVER_APP_ID,
     [SPACE_IDS]: spaceId != null ? [spaceId] : [],
     [ALERT_ANCESTORS]: ancestors,
-    [ALERT_STATUS]: 'open',
+    [ALERT_STATUS]: ALERT_STATUS_ACTIVE,
     [ALERT_WORKFLOW_STATUS]: 'open',
     [ALERT_DEPTH]: depth,
     [ALERT_REASON]: reason,

x-pack/plugins/uptime/public/lib/alert_types/duration_anomaly.tsx

@@ -8,7 +8,7 @@
 import React from 'react';
 import moment from 'moment';
 
-import { ALERT_END, ALERT_STATUS, ALERT_REASON } from '@kbn/rule-data-utils';
+import { ALERT_END, ALERT_STATUS, ALERT_STATUS_ACTIVE, ALERT_REASON } from '@kbn/rule-data-utils';
 
 import { AlertTypeInitializer } from '.';
 import { getMonitorRouteFromMonitorId } from './common';
@@ -39,7 +39,7 @@ export const initDurationAnomalyAlertType: AlertTypeInitializer = ({
     reason: fields[ALERT_REASON] || '',
     link: getMonitorRouteFromMonitorId({
       monitorId: fields['monitor.id']!,
-      dateRangeEnd: fields[ALERT_STATUS] === 'open' ? 'now' : fields[ALERT_END]!,
+      dateRangeEnd: fields[ALERT_STATUS] === ALERT_STATUS_ACTIVE ? 'now' : fields[ALERT_END]!,
       dateRangeStart: moment(new Date(fields['anomaly.start']!)).subtract('5', 'm').toISOString(),
     }),
   }),