Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LegacyRequest type from Core public API #109243

Merged
merged 4 commits into from
Aug 19, 2021
Merged

Remove LegacyRequest type from Core public API #109243

merged 4 commits into from
Aug 19, 2021

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Aug 19, 2021 •
edited
Loading

Summary

Removes LegacyRequest type from the Core public API contracts.
It shouldn't affect plugin developers - after the legacy platform removal, Kibana plugins do not have access to the Hapi Request object.

part of #77997

Plugin API changes

Core API doesn't accept LegacyRequest in BasePath and ScopeableRequet types anymore.

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 v7.16.0 labels Aug 19, 2021
@mshustov mshustov requested review from a team as code owners August 19, 2021 12:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

jportner
jportner approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, Security changes LGTM

@mshustov mshustov added the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 19, 2021
@mshustov mshustov enabled auto-merge (squash) August 19, 2021 13:14
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

API count

id before after diff
core 2260 2259 -1

API count missing comments

id before after diff
core 1006 1005 -1

References to deprecated APIs

id before after diff
security 2 0 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit fe96d3c into elastic:master Aug 19, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 19, 2021
@mshustov @kibanamachine
Remove LegacyRequest type from Core public API (elastic#109243)
d07f2cb 
* remove LegacyRequest from public API

* remove LegacyRequest from Security plugin API

* update docs

* remove an obsolete comment
@kibanamachine kibanamachine mentioned this pull request Aug 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

@mshustov mshustov deleted the remove-legacy-requrest-public-api branch August 19, 2021 15:23
kibanamachine added a commit that referenced this pull request Aug 19, 2021
@kibanamachine @mshustov
Remove LegacyRequest type from Core public API (#109243) (#109268)
e7f12de 
* remove LegacyRequest from public API

* remove LegacyRequest from Security plugin API

* update docs

* remove an obsolete comment

Co-authored-by: Mikhail Shustov <restrry@gmail.com>
This was referenced Nov 23, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@jportner jportner jportner approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mshustov @elasticmachine @kibanamachine @pgayvallet @jportner