Fix navigateToApp behavior when openInNewTab is true

[patrykkopycinski]

Summary

Untitled_.Sep.4.2021.1_49.AM.mp4

[patrykkopycinski]

@elasticmachine merge upstream

[kibanamachine]

expected head sha didn’t match current head ref.

[mshustov]

@patrykkopycinski Could add a link to an issue with a problem statement and steps to reproduce the problem, please?

[patrykkopycinski]

@mshustov attached the recording
To reproduce this issue:

1. Go to Cases app in the Security Solution
2. Create a case.
3. Add visualization to the Case comment.
4. After the comment is saved you can click on the comment actions menu and choose Open visualization option, it should open the Lens app in the new tab and also break the breadcrumbs on the Cases tab

[pgayvallet]

Yea, currentAppId$ shouldn't emit when we're opening in a new tab.

this.appInternalStates.delete(this.currentAppId$.value!);

should not be triggered either and should also be skipped. Could you please also fix this?

Index: src/core/public/application/application_service.tsx
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/core/public/application/application_service.tsx b/src/core/public/application/application_service.tsx
--- a/src/core/public/application/application_service.tsx	(revision 501e3150111867f0a100b49daf52463d05a12069)
+++ b/src/core/public/application/application_service.tsx	(date 1625645624318)
@@ -250,16 +250,15 @@
         if (path === undefined) {
           path = applications$.value.get(appId)?.defaultPath;
         }
-        if (!navigatingToSameApp) {
-          this.appInternalStates.delete(this.currentAppId$.value!);
-        }
         if (openInNewTab) {
           this.openInNewTab!(getAppUrl(availableMounters, appId, path));
         } else {
+          if (!navigatingToSameApp) {
+            this.appInternalStates.delete(this.currentAppId$.value!);
+          }
           this.navigate!(getAppUrl(availableMounters, appId, path), state, replace);
-        }
-
-        this.currentAppId$.next(appId);
+          this.currentAppId$.next(appId);
+        }
       }
     };
 

[shahzad31]

LGTM !!

[patrykkopycinski]

@elasticmachine merge upstream

[patrykkopycinski]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: f5b425c
• Storybooks Preview

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
core	293.6KB	293.6KB	+2.0B

History

• 💚 Build #154052 succeeded c1c7e5e
• 💚 Build #150828 succeeded 2f33363
• 💚 Build #150763 succeeded 0d7d6f9
• 💔 Build #149971 failed abfc7fe

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @patrykkopycinski

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.x
✅	7.15

The backport PRs will be merged automatically after passing CI.