Resurrect deprecated and removed authentication settings. #110835
Conversation
azasypkin
added
Team:Security
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-security (Team:Security) |
| @@ -13,6 +13,7 @@ export const securityConfigDeprecationProvider: ConfigDeprecationProvider = ({ | |||
| unused, | |||
| }) => [ | |||
| rename('sessionTimeout', 'session.idleTimeout'), | |||
| rename('authProviders', 'authc.providers'), | |||
There was a problem hiding this comment.
It's not clear to me why you're mapping between authProviders and authc.providers - is this reflected in the documentation?
There was a problem hiding this comment.
Yeah, it's in our old docs. The authProviders: string[] was the first authc-related configuration we introduced in 6.2/3, then we migrated to a authc.providers: string[] in anticipation to support a more complex authc.providers: Record<string, MoreComplexStructure> in the future (that's what we have today).
With this rename we just continue to support this ancient authProviders: string[] format.
There was a problem hiding this comment.
Our deprecation handling logic will transform this:
xpack.security.authProviders: [basic]first to this (with rename):
xpack.security.authc.providers: [basic]and then to this (with custom deprecation transformer):
xpack.security.authc.providers.basic.basic.order: 0
azasypkin
added
the
auto-backport
💔 Backport failed
To backport manually run: |
Summary
Resurrect deprecated and removed authentication settings.
Note to reviewers: almost everything is copied from
7.xbranch. It turned out integration tests inmasterand7.xalready have a reasonable mix of tests that use old and new authc config, so I didn't add anything, except forauthc.providers -> authProvidersswitch in OIDC API integration tests (just to have some tests with the oldest config format).