Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Improve xpack.security.session deprecation warnings #111531

Merged
merged 8 commits into from
Sep 10, 2021

Conversation

watson
Copy link
Contributor

@watson watson commented Sep 8, 2021

This PR adds a title field to the two deprecation warnings and wraps all their text in i18n handlers. This brings them "up to speed" with the other deprecation warnings in this file.

Without the title field, a title would be generated automatically and it would not be possible to tell the two deprecations apart in the overview:

image

With this change, they now look like this:

image

@watson watson added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v7.16.0 labels Sep 8, 2021
@watson watson self-assigned this Sep 8, 2021
@watson watson marked this pull request as ready for review September 8, 2021 15:28
x-pack/plugins/security/server/config_deprecations.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/config_deprecations.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/config_deprecations.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/config_deprecations.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/config_deprecations.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/config_deprecations.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/config_deprecations.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/config_deprecations.ts Outdated Show resolved Hide resolved
Co-authored-by: debadair <debadair@elastic.co>
@watson
Copy link
Contributor Author

watson commented Sep 10, 2021

@elasticmachine merge upstream

@watson
Copy link
Contributor Author

watson commented Sep 10, 2021

I just added the newly introduced level field so that we could get these to show up as warning instead of critical. This is how it looks:

image

Besides that, here's how the detailed message now looks with all the review comments taken into account:

image

@watson watson enabled auto-merge (squash) September 10, 2021 12:07
@watson
Copy link
Contributor Author

watson commented Sep 10, 2021

Now with proper quotes:

image

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

@watson watson merged commit d389bf5 into elastic:7.x Sep 10, 2021
@watson watson deleted the deprecation-xpack-security-session branch September 10, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants