Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] Add breadcrumb support #111850

Merged
merged 5 commits into from
Sep 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
289 changes: 289 additions & 0 deletions x-pack/plugins/monitoring/public/application/hooks/use_breadcrumbs.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,289 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import { useCallback, useEffect, useState } from 'react';
import { i18n } from '@kbn/i18n';
import createContainer from 'constate';
import { History } from 'history';
import { Observable } from 'rxjs';
import { useKibana } from '../../../../../../src/plugins/kibana_react/public';

interface Crumb {
url?: string | null;
label: string;
ignoreGlobalState: boolean;
testSubj?: string;
}
// Helper for making objects to use in a link element
const createCrumb = (
url: string | null,
label: string,
testSubj?: string,
ignoreGlobalState = false
) => {
const crumb: Crumb = { url, label, ignoreGlobalState };
if (testSubj) {
crumb.testSubj = testSubj;
}
return crumb;
};

// generate Elasticsearch breadcrumbs
function getElasticsearchBreadcrumbs(mainInstance: any) {
const breadcrumbs = [];
if (mainInstance.instance) {
breadcrumbs.push(createCrumb('#/elasticsearch', 'Elasticsearch'));
if (mainInstance.name === 'indices') {
breadcrumbs.push(
createCrumb(
'#/elasticsearch/indices',
i18n.translate('xpack.monitoring.breadcrumbs.es.indicesLabel', {
defaultMessage: 'Indices',
}),
'breadcrumbEsIndices'
)
);
} else if (mainInstance.name === 'nodes') {
breadcrumbs.push(
createCrumb(
'#/elasticsearch/nodes',
i18n.translate('xpack.monitoring.breadcrumbs.es.nodesLabel', { defaultMessage: 'Nodes' }),
'breadcrumbEsNodes'
)
);
} else if (mainInstance.name === 'ml') {
// ML Instance (for user later)
breadcrumbs.push(
createCrumb(
'#/elasticsearch/ml_jobs',
i18n.translate('xpack.monitoring.breadcrumbs.es.jobsLabel', {
defaultMessage: 'Machine learning jobs',
})
)
);
} else if (mainInstance.name === 'ccr_shard') {
breadcrumbs.push(
createCrumb(
'#/elasticsearch/ccr',
i18n.translate('xpack.monitoring.breadcrumbs.es.ccrLabel', { defaultMessage: 'CCR' })
)
);
}
breadcrumbs.push(createCrumb(null, mainInstance.instance));
} else {
// don't link to Overview when we're possibly on Overview or its sibling tabs
breadcrumbs.push(createCrumb(null, 'Elasticsearch'));
}
return breadcrumbs;
}

// generate Kibana breadcrumbs
function getKibanaBreadcrumbs(mainInstance: any) {
const breadcrumbs = [];
if (mainInstance.instance) {
breadcrumbs.push(createCrumb('#/kibana', 'Kibana'));
breadcrumbs.push(
createCrumb(
'#/kibana/instances',
i18n.translate('xpack.monitoring.breadcrumbs.kibana.instancesLabel', {
defaultMessage: 'Instances',
})
)
);
breadcrumbs.push(createCrumb(null, mainInstance.instance));
} else {
// don't link to Overview when we're possibly on Overview or its sibling tabs
breadcrumbs.push(createCrumb(null, 'Kibana'));
}
return breadcrumbs;
}

// generate Logstash breadcrumbs
function getLogstashBreadcrumbs(mainInstance: any) {
const logstashLabel = i18n.translate('xpack.monitoring.breadcrumbs.logstashLabel', {
defaultMessage: 'Logstash',
});
const breadcrumbs = [];
if (mainInstance.instance) {
breadcrumbs.push(createCrumb('#/logstash', logstashLabel));
if (mainInstance.name === 'nodes') {
breadcrumbs.push(
createCrumb(
'#/logstash/nodes',
i18n.translate('xpack.monitoring.breadcrumbs.logstash.nodesLabel', {
defaultMessage: 'Nodes',
})
)
);
}
breadcrumbs.push(createCrumb(null, mainInstance.instance));
} else if (mainInstance.page === 'pipeline') {
breadcrumbs.push(createCrumb('#/logstash', logstashLabel));
breadcrumbs.push(
createCrumb(
'#/logstash/pipelines',
i18n.translate('xpack.monitoring.breadcrumbs.logstash.pipelinesLabel', {
defaultMessage: 'Pipelines',
})
)
);
} else {
// don't link to Overview when we're possibly on Overview or its sibling tabs
breadcrumbs.push(createCrumb(null, logstashLabel));
}

return breadcrumbs;
}

// generate Beats breadcrumbs
function getBeatsBreadcrumbs(mainInstance: any) {
const beatsLabel = i18n.translate('xpack.monitoring.breadcrumbs.beatsLabel', {
defaultMessage: 'Beats',
});
const breadcrumbs = [];
if (mainInstance.instance) {
breadcrumbs.push(createCrumb('#/beats', beatsLabel));
breadcrumbs.push(
createCrumb(
'#/beats/beats',
i18n.translate('xpack.monitoring.breadcrumbs.beats.instancesLabel', {
defaultMessage: 'Instances',
})
)
);
breadcrumbs.push(createCrumb(null, mainInstance.instance));
} else {
breadcrumbs.push(createCrumb(null, beatsLabel));
}

return breadcrumbs;
}

// generate Apm breadcrumbs
function getApmBreadcrumbs(mainInstance: any) {
const apmLabel = i18n.translate('xpack.monitoring.breadcrumbs.apmLabel', {
defaultMessage: 'APM server',
});
const breadcrumbs = [];
if (mainInstance.instance) {
breadcrumbs.push(createCrumb('#/apm', apmLabel));
breadcrumbs.push(
createCrumb(
'#/apm/instances',
i18n.translate('xpack.monitoring.breadcrumbs.apm.instancesLabel', {
defaultMessage: 'Instances',
})
)
);
breadcrumbs.push(createCrumb(null, mainInstance.instance));
} else {
// don't link to Overview when we're possibly on Overview or its sibling tabs
breadcrumbs.push(createCrumb(null, apmLabel));
}
return breadcrumbs;
}

function buildBreadcrumbs(clusterName: string, mainInstance?: any | null) {
const homeCrumb = i18n.translate('xpack.monitoring.breadcrumbs.clustersLabel', {
defaultMessage: 'Clusters',
});

let breadcrumbs = [createCrumb('#/home', homeCrumb, 'breadcrumbClusters', true)];

if (!mainInstance?.inOverview && clusterName) {
breadcrumbs.push(createCrumb('#/overview', clusterName));
}

if (mainInstance?.inElasticsearch) {
breadcrumbs = breadcrumbs.concat(getElasticsearchBreadcrumbs(mainInstance));
}
if (mainInstance?.inKibana) {
breadcrumbs = breadcrumbs.concat(getKibanaBreadcrumbs(mainInstance));
}
if (mainInstance?.inLogstash) {
breadcrumbs = breadcrumbs.concat(getLogstashBreadcrumbs(mainInstance));
}
if (mainInstance?.inBeats) {
breadcrumbs = breadcrumbs.concat(getBeatsBreadcrumbs(mainInstance));
}
if (mainInstance?.inApm) {
breadcrumbs = breadcrumbs.concat(getApmBreadcrumbs(mainInstance));
}

return breadcrumbs;
}
interface BreadcrumbItem {
['data-test-subj']?: string;
href?: string;
text: string;
ignoreGlobalState?: boolean;
}

export const useBreadcrumbs = ({ history }: { history: History }) => {
const chrome = useKibana().services.chrome;
const [breadcrumbs, setBreadcrumbs] = useState<Crumb[]>([]);

const update = useCallback(
(bcrumbs?: BreadcrumbItem[]) => {
if (!chrome) return;
if (!bcrumbs) {
const currentBreadcrumbs: Observable<any> & {
value?: BreadcrumbItem[];
} = chrome.getBreadcrumbs$()?.source;
if (currentBreadcrumbs && currentBreadcrumbs.value) {
bcrumbs = currentBreadcrumbs.value;
}
}
const globalStateStr = location.hash.split('?')[1];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direct location hash parsing was a little surprising to see. I was expected we'd already have some sort of kibana level breadcrumb manager that look care of this sort of thing, but maybe not?

Seems like we should probably have a test on this, if not now then before we call the react conversion "done".

if (
!bcrumbs?.length ||
globalStateStr?.indexOf('_g') !== 0 ||
bcrumbs[0].href?.split('?')[1] === globalStateStr
) {
return;
}
bcrumbs.forEach((breadcrumb: BreadcrumbItem) => {
const breadcrumbHref = breadcrumb.href?.split('?')[0];
if (breadcrumbHref && !breadcrumb.ignoreGlobalState) {
breadcrumb.href = `${breadcrumbHref}?${globalStateStr}`;
}
delete breadcrumb.ignoreGlobalState;
});
chrome.setBreadcrumbs(bcrumbs.slice(0));
},
[chrome]
);

const generate = useCallback(
(cluster: string, mainInstance?: any) => {
const crumbs = buildBreadcrumbs(cluster, mainInstance);
setBreadcrumbs(crumbs);
update(
crumbs.map((b) => ({
text: b.label,
href: b.url ? b.url : undefined,
'data-test-subj': b.testSubj,
ignoreGlobalState: b.ignoreGlobalState,
}))
);
},
[setBreadcrumbs, update]
);

useEffect(() => {
history.listen((location, action) => {
update();
});
}, [history, update]);

return {
generate,
update,
breadcrumbs,
};
};

export const BreadcrumbContainer = createContainer(useBreadcrumbs);
65 changes: 34 additions & 31 deletions x-pack/plugins/monitoring/public/application/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ import { GlobalStateProvider } from './global_state_context';
import { ExternalConfigContext, ExternalConfig } from './external_config_context';
import { createPreserveQueryHistory } from './preserve_query_history';
import { RouteInit } from './route_init';
import { MonitoringTimeContainer } from './pages/use_monitoring_time';
import { MonitoringTimeContainer } from './hooks/use_monitoring_time';
import { BreadcrumbContainer } from './hooks/use_breadcrumbs';

export const renderApp = (
core: CoreStart,
Expand Down Expand Up @@ -48,36 +49,38 @@ const MonitoringApp: React.FC<{
<ExternalConfigContext.Provider value={externalConfig}>
<GlobalStateProvider query={plugins.data.query} toasts={core.notifications.toasts}>
<MonitoringTimeContainer.Provider>
<Router history={history}>
<Switch>
<Route path="/no-data" component={NoData} />
<Route path="/loading" component={LoadingPage} />
<RouteInit
path="/license"
component={LicensePage}
codePaths={['all']}
fetchAllClusters={false}
/>
<RouteInit
path="/home"
component={Home}
codePaths={['all']}
fetchAllClusters={false}
/>
<RouteInit
path="/overview"
component={ClusterOverview}
codePaths={['all']}
fetchAllClusters={false}
/>
<Redirect
to={{
pathname: '/loading',
search: history.location.search,
}}
/>
</Switch>
</Router>
<BreadcrumbContainer.Provider history={history}>
<Router history={history}>
<Switch>
<Route path="/no-data" component={NoData} />
<Route path="/loading" component={LoadingPage} />
<RouteInit
path="/license"
component={LicensePage}
codePaths={['all']}
fetchAllClusters={false}
/>
<RouteInit
path="/home"
component={Home}
codePaths={['all']}
fetchAllClusters={false}
/>
<RouteInit
path="/overview"
component={ClusterOverview}
codePaths={['all']}
fetchAllClusters={false}
/>
<Redirect
to={{
pathname: '/loading',
search: history.location.search,
}}
/>
</Switch>
</Router>
</BreadcrumbContainer.Provider>
</MonitoringTimeContainer.Provider>
</GlobalStateProvider>
</ExternalConfigContext.Provider>
Expand Down
Loading