Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.15] [Security Solution] Add host.os.name.caseless mapping and runtime field (#111455) #111871

Closed

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.15:

…ld (elastic#111455)

* Add host.os.name.caseless field and runtime field

* Tests

* Only add backwards compatibility mappings to old indices by version

* Always update aliases_version field even if there are no compat mappings

* Add test for newest index version

* More comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@marshallmain
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor Author

kibanamachine commented Sep 14, 2021

💔 Build Failed

Failed CI Steps


Test Failures

Kibana Pipeline / jest / Jest Tests.x-pack/plugins/security_solution/server/lib/detection_engine/routes/index.get_signals_template backwards compatibility mappings for version 45 should match snapshot

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `get_signals_template backwards compatibility mappings for version 45 should match snapshot 1`

- Snapshot  - 4
+ Received  + 4

@@ -150,10 +150,14 @@
      },
      "kibana.alert.rule.from": Object {
        "path": "signal.rule.from",
        "type": "alias",
      },
+     "kibana.alert.rule.id": Object {
+       "path": "signal.rule.id",
+       "type": "alias",
+     },
      "kibana.alert.rule.immutable": Object {
        "path": "signal.rule.immutable",
        "type": "alias",
      },
      "kibana.alert.rule.index": Object {
@@ -332,14 +336,10 @@
        "path": "signal.rule.updated_at",
        "type": "alias",
      },
      "kibana.alert.rule.updated_by": Object {
        "path": "signal.rule.updated_by",
-       "type": "alias",
-     },
-     "kibana.alert.rule.uuid": Object {
-       "path": "signal.rule.id",
        "type": "alias",
      },
      "kibana.alert.rule.version": Object {
        "path": "signal.rule.version",
        "type": "alias",
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/security_solution/server/lib/detection_engine/routes/index/get_signals_template.test.ts:130:21)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:57:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @marshallmain

auto-merge was automatically disabled September 14, 2021 04:33

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants