[Maps] remove VectorSourceSyncMeta type #112333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
thomasneirynck
approved these changes
Sep 15, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 16, 2021
* [Maps] remove VectorSourceSyncMeta type * add comment to getSyncMeta * document join.getSyncMeta Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 16, 2021
* [Maps] remove VectorSourceSyncMeta type * add comment to getSyncMeta * document join.getSyncMeta Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
9 tasks
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of type clean-up to support #111228
This PR removes
VectorSourceSyncMetatype. It was used to typeVectorSourceRequestMeta.sourceMeta.VectorSourceRequestMeta.sourceMetais only used incanSkipSourceUpdateto trigger an updated if source properties have changed that required a re-fetch. TypingVectorSourceRequestMeta.sourceMetaas Object is specific enough for this check. Strictly typingVectorSourceRequestMeta.sourceMetaleaked source implemenation details intoVectorSourceRequestMetaand made adding sources at run time difficult.