Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] move registerLayerWizard and registerSource to MapsSetupApi #112465

Merged
merged 5 commits into from
Sep 22, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Sep 16, 2021

Move registerLayerWizard and registerSource to MapsSetupApi and export types needed in #111228

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 16, 2021
@nreese nreese requested a review from a team as a code owner September 16, 2021 18:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Sep 20, 2021

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Sep 20, 2021

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Sep 22, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
maps 833 834 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
maps 102 198 +96

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +4.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
maps 20 29 +9

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
maps 44.3KB 44.2KB -36.0B
Unknown metric groups

API count

id before after diff
maps 103 199 +96

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit a753f83 into elastic:master Sep 22, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 112465

nreese added a commit to nreese/kibana that referenced this pull request Sep 22, 2021
…lastic#112465)

* [maps] move registerLayerWizard and registerSource to MapsSetupApi

* eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/maps/public/plugin.ts
@nreese
Copy link
Contributor Author

nreese commented Sep 22, 2021

7.16 bactport #112855

nreese added a commit that referenced this pull request Sep 22, 2021
…112465) (#112855)

* [maps] move registerLayerWizard and registerSource to MapsSetupApi

* eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	x-pack/plugins/maps/public/plugin.ts
lykkin pushed a commit to lykkin/kibana that referenced this pull request Sep 28, 2021
…lastic#112465)

* [maps] move registerLayerWizard and registerSource to MapsSetupApi

* eslint

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants