Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing jest tests with unhandled promise rejections #112804

Merged
merged 1 commit into from
Sep 22, 2021
Merged

[ML] Fixing jest tests with unhandled promise rejections #112804

merged 1 commit into from
Sep 22, 2021

Conversation

jgowdyelastic
Copy link
Member

Relates to #112699

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience non-issue Indicates to automation that a pull request should not appear in the release notes :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 22, 2021
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner September 22, 2021 10:15
@jgowdyelastic jgowdyelastic self-assigned this Sep 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson mentioned this pull request Sep 22, 2021
Closed
23 tasks
walterra
walterra approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +18.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit 1456257 into elastic:master Sep 22, 2021
@jgowdyelastic jgowdyelastic deleted the fix-jest-test-with-unhandled-promise-rejections branch September 22, 2021 13:31
@kibanamachine kibanamachine mentioned this pull request Sep 22, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 22, 2021
@jgowdyelastic @kibanamachine
[ML] Fixing jest tests with unhandled promise rejections (elastic#112804
8326268 
)
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Sep 22, 2021
@kibanamachine @jgowdyelastic
[ML] Fixing jest tests with unhandled promise rejections (#112804) (#…
bd2ef02 
…112829)

Co-authored-by: James Gowdy <jgowdy@elastic.co>
lykkin pushed a commit to lykkin/kibana that referenced this pull request Sep 28, 2021
@jgowdyelastic @lykkin
[ML] Fixing jest tests with unhandled promise rejections (elastic#112804
88c423a 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @walterra @peteharverson