-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Removing SavedObject usage for savedSearch #112983
Merged
alexwizp
merged 34 commits into
elastic:master
from
alexwizp:discover-saved-object-loader
Oct 13, 2021
Merged
Changes from 28 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
bb3da54
[Discover] Step 2 - remove SavedObjectLoader
alexwizp 38258c5
Fix PR comments
alexwizp 0a8623e
Merge branch 'master' into discover-saved-object-loader
kibanamachine a8df731
fix test names
alexwizp 7f3f676
fix ts error
alexwizp dc3ee7b
add handling of missed 'so'
alexwizp 232109d
add Embeddable error
alexwizp b3d256c
Merge remote-tracking branch 'upstream/main' into discover-saved-obje…
alexwizp 03214e3
fix jest
alexwizp 64c29b6
add DiscoverError component
alexwizp 9d31455
Merge remote-tracking branch 'upstream/master' into discover-saved-ob…
alexwizp 21af3ec
fix Joe comments
alexwizp eaa583b
add search params
alexwizp 7178e31
Merge remote-tracking branch 'upstream/main' into discover-saved-obje…
alexwizp 88e517e
add throwErrorOnUrlConflict util method
alexwizp 465625f
add error handling into transform plugin
alexwizp e93c44e
do some updates
alexwizp 85cfdb1
add spaces into visualize, visualizations
alexwizp c52ba68
Merge remote-tracking branch 'upstream/main' into discover-saved-obje…
alexwizp 17d5516
fix Tim's comment
alexwizp e876ddb
Merge remote-tracking branch 'upstream/main' into discover-saved-obje…
alexwizp dc4a0ad
Merge branch 'master' into discover-saved-object-loader
kibanamachine 7aebc9c
Merge remote-tracking branch 'upstream/master' into discover-saved-ob…
alexwizp 06c15de
pass false into createGetterSetter for getSpaces
alexwizp dfeef9c
Merge branch 'master' into discover-saved-object-loader
kibanamachine db1e59b
Merge branch 'master' into discover-saved-object-loader
kibanamachine fe00324
Merge branch 'master' into discover-saved-object-loader
kibanamachine 150a2ca
Merge branch 'master' into discover-saved-object-loader
kibanamachine 54a9508
Merge branch 'master' into discover-saved-object-loader
kibanamachine a86d821
Merge remote-tracking branch 'upstream/master' into discover-saved-ob…
VladLasitsa ff973c5
Fix comments
VladLasitsa 5bf1a0e
Fix lint
VladLasitsa 4814a0a
Merge branch 'master' into discover-saved-object-loader
kibanamachine 76ee791
Merge remote-tracking branch 'upstream/main' into discover-saved-obje…
alexwizp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement 👍