Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Search] Wired up Suggestion detail data #113796

Merged
merged 5 commits into from
Oct 4, 2021
Merged

Conversation

JasonStoltz
Copy link
Member

Summary

This PR wires up the Suggested section of the Curation Suggestion Detail view.

Note that ONLY the section in red is wired up, the remaining panels on the screen are still static.

export

To test with suggestions, use the following API endpoint:

curl --location --request POST 'localhost:3002/api/as/v0/engines/national-parks-demo/create_search_relevance_suggestions' \
--header 'Authorization: Basic xxxxx' \
--header 'Content-Type: application/json' \
--data-raw '{
      "query" : "test2",
      "type": "curation",
      "status": "pending",
      "promoted": ["park_grand-teton", "park_hot-springs"],
      "operation": "create"
}'

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@JasonStoltz JasonStoltz added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 4, 2021
@JasonStoltz JasonStoltz requested a review from a team October 4, 2021 16:03
Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>
@JasonStoltz JasonStoltz enabled auto-merge (squash) October 4, 2021 17:16
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1503 1504 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.3MB 1.3MB +2.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@JasonStoltz JasonStoltz merged commit 2dac93c into master Oct 4, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 113796

@JasonStoltz JasonStoltz deleted the suggestion-detail-data branch October 5, 2021 13:30
byronhulcher pushed a commit to byronhulcher/kibana that referenced this pull request Oct 5, 2021
byronhulcher added a commit that referenced this pull request Oct 5, 2021
* [App Search] Wired up Suggestion detail data (#113796)

* Fix mock value after type update in #113861

* Fix test after type update in #113861

Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants