[Maps] do not lazy load setup API methods #114150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
9 tasks
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
thomasneirynck
approved these changes
Oct 6, 2021
nreese
added
the
auto-backport
💔 Backport failed
To backport manually run: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 7, 2021
* [Maps] do not lazy load setup API methods * remove test code # Conflicts: # x-pack/plugins/maps/public/lazy_load_bundle/index.ts
|
7.x #114220 |
nreese
added a commit
that referenced
this pull request
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#113857 (comment) identified a regression caused when registerLayerWizard and registerSource were moved from start API to setup API. The problem is that using lazy load imports kibana_services which has not been populated when setup is called. This PR just removes the lazy loading for registerLayerWizard and registerSource.