[Stack Monitoring] Enable react stack monitoring by default #114436

matschaffer · 2021-10-11T08:03:42Z

Summary

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-10-11T08:03:45Z

Pinging @elastic/stack-monitoring (Team:Monitoring)

elasticmachine · 2021-10-11T08:03:48Z

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

matschaffer · 2021-10-12T07:42:33Z

@elasticmachine merge upstream

matschaffer · 2021-10-13T02:57:58Z

@elasticmachine merge upstream

matschaffer · 2021-10-14T05:10:52Z

@elasticmachine merge upstream

matschaffer · 2021-10-14T11:09:23Z

@elasticmachine merge upstream

neptunian · 2021-10-14T12:38:00Z

@elasticmachine merge upstream

estermv · 2021-10-14T13:59:01Z

@elasticmachine merge upstream

neptunian · 2021-10-14T19:42:30Z

@elasticmachine merge upstream

neptunian · 2021-10-14T20:49:26Z

@elasticmachine merge upstream

phillipb

…114436) * Enable react stack monitoring by default * Also update test snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-10-14T23:48:55Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

kibanamachine · 2021-10-15T05:38:11Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 3ceb8f5
Storybooks Preview
Flaky suites:
- xpack-kibana-ciGroup6

Test Failures

Kibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/search/session·ts.apis search search session touched time updates when you poll on an search

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]     │
[00:00:00]       └-: apis
[00:00:00]         └-> "before all" hook in "apis"
[00:00:00]         └-: search
[00:00:00]           └-> "before all" hook in "search"
[00:00:03]           └-: search session
[00:00:03]             └-> "before all" hook for "should fail to extend a nonexistent session"
[00:00:03]             └-> should fail to extend a nonexistent session
[00:00:03]               └-> "before each" hook: global before each for "should fail to extend a nonexistent session"
[00:00:03]               │ proc [kibana] [2021-10-15T04:15:14.054+00:00][ERROR][plugins.dataEnhanced.data_enhanced] [object Object]
[00:00:03]               └- ✓ pass  (70ms)
[00:00:03]             └-> should sync search ids into not persisted session
[00:00:03]               └-> "before each" hook: global before each for "should sync search ids into not persisted session"
[00:00:03]               │ debg Waiting up to 5000ms for searches persisted into session...
[00:00:03]               │ proc [kibana] [2021-10-15T04:15:14.210+00:00][ERROR][plugins.dataEnhanced.data_enhanced] [object Object]
[00:00:03]               │ debg --- retry.waitForWithTimeout error: expected 200 "OK", got 404 "Not Found"
[00:00:04]               │ proc [kibana] [2021-10-15T04:15:14.791+00:00][ERROR][plugins.dataEnhanced.data_enhanced] [object Object]
[00:00:04]               │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:00:04]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/s3YTipj5RAiAgCObPdDkJg] update_mapping [_doc]
[00:00:04]               └- ✓ pass  (1.3s)
[00:00:04]             └-> should complete session when searches complete
[00:00:04]               └-> "before each" hook: global before each for "should complete session when searches complete"
[00:00:04]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.ds-.logs-deprecation.elasticsearch-default-2021.10.15-000001/N9R-7CrTS_CUrNAIfbNbCw] update_mapping [_doc]
[00:00:04]               │ debg Waiting up to 5000ms for searches persisted into session...
[00:00:04]               │ debg --- retry.waitForWithTimeout error: expected [] to contain 'Fm5iQ2g3SzJpVG42cFpYM2Zib2l3SUEbcGcyYVpmY1FUNXVmcnFVNU9ES3ZudzoyMjc0'
[00:00:05]               │ debg --- retry.waitForWithTimeout failed again with the same message...
[00:00:08]               │ info [o.e.c.m.MetadataMappingService] [node-01] [.kibana_8.0.0_001/s3YTipj5RAiAgCObPdDkJg] update_mapping [_doc]
[00:00:16]               │ debg Waiting up to 5000ms for searches eventually complete and session gets into the complete state...
[00:00:16]               └- ✓ pass  (11.4s)
[00:00:16]             └-> touched time updates when you poll on an search
[00:00:16]               └-> "before each" hook: global before each for "touched time updates when you poll on an search"
[00:00:16]               │ debg Waiting up to 20000ms for search session created...
[00:00:16]               │ proc [kibana] [2021-10-15T04:15:26.873+00:00][ERROR][plugins.dataEnhanced.data_enhanced] [object Object]
[00:00:16]               │ proc [kibana] [2021-10-15T04:15:27.436+00:00][ERROR][plugins.dataEnhanced.data_enhanced] [object Object]
[00:00:20]               └- ✖ fail: apis search search session touched time updates when you poll on an search
[00:00:20]               │      Error: expected '2021-10-15T04:15:27.855Z' to be below 2021-10-15T04:15:27.855Z
[00:00:20]               │       at Assertion.assert (/dev/shm/workspace/parallel/10/kibana/node_modules/@kbn/expect/expect.js:100:11)
[00:00:20]               │       at Assertion.lessThan.Assertion.below (/dev/shm/workspace/parallel/10/kibana/node_modules/@kbn/expect/expect.js:336:8)
[00:00:20]               │       at Function.lessThan (/dev/shm/workspace/parallel/10/kibana/node_modules/@kbn/expect/expect.js:531:15)
[00:00:20]               │       at Context.<anonymous> (test/api_integration/apis/search/session.ts:438:65)
[00:00:20]               │       at runMicrotasks (<anonymous>)
[00:00:20]               │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:00:20]               │       at Object.apply (/dev/shm/workspace/parallel/10/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
[00:00:20]               │ 
[00:00:20]               │

Stack Trace

Error: expected '2021-10-15T04:15:27.855Z' to be below 2021-10-15T04:15:27.855Z
    at Assertion.assert (/dev/shm/workspace/parallel/10/kibana/node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.lessThan.Assertion.below (/dev/shm/workspace/parallel/10/kibana/node_modules/@kbn/expect/expect.js:336:8)
    at Function.lessThan (/dev/shm/workspace/parallel/10/kibana/node_modules/@kbn/expect/expect.js:531:15)
    at Context.<anonymous> (test/api_integration/apis/search/session.ts:438:65)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Object.apply (/dev/shm/workspace/parallel/10/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

Metrics [docs]

✅ unchanged

History

💚 Build #161179 succeeded 3ceb8f5
💔 Build #161152 failed 2299a02
💔 Build #160929 failed 3549ee3
💔 Build #160880 failed 2918dcb
💔 Build #160838 failed dffd850

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @matschaffer

…#115120) * Enable react stack monitoring by default * Also update test snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Mat Schaffer <mat@elastic.co>

…114436) * Enable react stack monitoring by default * Also update test snapshot Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Enable react stack monitoring by default

e00c92d

matschaffer requested a review from a team as a code owner October 11, 2021 08:03

matschaffer self-assigned this Oct 11, 2021

matschaffer requested review from a team October 11, 2021 08:03

matschaffer mentioned this pull request Oct 11, 2021

React on by default #113945

Closed

9 tasks

matschaffer changed the title ~~Enable react stack monitoring by default~~ [Stack Monitoring] Enable react stack monitoring by default Oct 11, 2021

Also update test snapshot

80bdbca

Merge branch 'master' into 111309-monitoring-react

3f93705

Merge branch 'master' into 111309-monitoring-react

12802ba

Merge branch 'master' into 111309-monitoring-react

1685275

matschaffer mentioned this pull request Oct 14, 2021

[Stack Monitoring] feature_controls functional tests #114638

Closed

Merge branch 'master' into 111309-monitoring-react

dffd850

Merge branch 'master' into 111309-monitoring-react

2918dcb

Merge branch 'master' into 111309-monitoring-react

3549ee3

Merge branch 'master' into 111309-monitoring-react

2299a02

Merge branch 'master' into 111309-monitoring-react

3ceb8f5

matschaffer enabled auto-merge (squash) October 14, 2021 23:38

phillipb approved these changes Oct 14, 2021

View reviewed changes

matschaffer merged commit 45f02d3 into elastic:master Oct 14, 2021

kibanamachine mentioned this pull request Oct 14, 2021

[7.x] [Stack Monitoring] Enable react stack monitoring by default (#114436) #115120

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Stack Monitoring] Enable react stack monitoring by default #114436

[Stack Monitoring] Enable react stack monitoring by default #114436

matschaffer commented Oct 11, 2021 •

edited

Loading

elasticmachine commented Oct 11, 2021

elasticmachine commented Oct 11, 2021

matschaffer commented Oct 12, 2021

matschaffer commented Oct 13, 2021

matschaffer commented Oct 14, 2021

matschaffer commented Oct 14, 2021

neptunian commented Oct 14, 2021

estermv commented Oct 14, 2021

neptunian commented Oct 14, 2021

neptunian commented Oct 14, 2021

phillipb left a comment

kibanamachine commented Oct 14, 2021

kibanamachine commented Oct 15, 2021

Standard Out

Stack Trace

[Stack Monitoring] Enable react stack monitoring by default #114436

[Stack Monitoring] Enable react stack monitoring by default #114436

Conversation

matschaffer commented Oct 11, 2021 • edited Loading

Summary

Checklist

Risk Matrix

For maintainers

elasticmachine commented Oct 11, 2021

elasticmachine commented Oct 11, 2021

matschaffer commented Oct 12, 2021

matschaffer commented Oct 13, 2021

matschaffer commented Oct 14, 2021

matschaffer commented Oct 14, 2021

neptunian commented Oct 14, 2021

estermv commented Oct 14, 2021

neptunian commented Oct 14, 2021

neptunian commented Oct 14, 2021

phillipb left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 14, 2021

💚 Backport successful

kibanamachine commented Oct 15, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

History

matschaffer commented Oct 11, 2021 •

edited

Loading