Report shard failures in the field_capabilities response #11450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
++ for working on this in 5.x and up-porting to master |
|
The code looks good to me. Need to set up the test case and run it. Thanks for doing this! |
Bargs
force-pushed
the
reportShardFailures
branch
from
f1c5657
to
236ba4d
Compare
Bargs
force-pushed
the
reportShardFailures
branch
from
236ba4d
to
950a4e7
Compare
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Apr 28, 2017
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
Apr 28, 2017
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
May 1, 2017
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
May 1, 2017
Bargs
added a commit
to Bargs/kibana
that referenced
this pull request
May 1, 2017
Bargs
added a commit
that referenced
this pull request
May 2, 2017
Bargs
added a commit
that referenced
this pull request
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11379
Summary: The Kibana field_capabilities API will now include any shard failures in its response so that the user is notified when an error has occurred while creating an index pattern or refreshing a pattern's fields.
I wasn't totally sure how to how to submit this PR since the error isn't reproducible in master, since you can't migrate an index directly from 2.x -> 6.x. You could theoretically get a shard failure for other reasons though, so we do want this fix in master. I've submitted the PR against 5.x for ease of testing but I'll merge into master first once it's approved.