[Alerting] Show execution duration on Rule Details view #114719

ymao1 · 2021-10-12T20:07:42Z

Summary

Added summary of execution durations to Rule Details view, with warning when the average execution duration exceeds the rule timeout

Rule with status: active and 30 most recent execution durations with average

Rule where last execution ended in error

Rule where no execution data is available yet

Rule where average execution duration exceeds rule timeout

Rule where execution duration suddenly spikes

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

…ing/show-durations-rule-details

elasticmachine · 2021-10-14T13:38:05Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

ymao1 · 2021-10-14T14:16:52Z

...triggers_actions_ui/public/application/sections/alert_details/components/alert_instances.tsx

@@ -37,6 +66,8 @@ type AlertInstancesProps = {
  durationEpoch?: number;
 } & Pick<AlertApis, 'muteAlertInstance' | 'unmuteAlertInstance'>;

+const DESIRED_NUM_EXECUTION_DURATIONS = 30;


We are piggybacking on the existing event log query to retrieve the execution duration information. The existing query looks back 60*schedule interval, so due to scheduling drift, we actually get 50-ish to 60 executions. In order to maintain a more consistent chart experience, we're truncating to 30. In the future, we can think about performing a separate query specifically for execution durations (and using aggregations for the avg) and when we do that, we would be able to specify exactly the number of executions to show.

I've opened this issue separate out the query for execution durations in the future, which would allow us to show a dropdown for users to select the number they want to see.

mdefazio

Have some feedback on title sizes and flexbox widths. Happy to chat about these if i'm not clear on my comments—hopefully put them in the right spot :)

...triggers_actions_ui/public/application/sections/alert_details/components/alert_instances.tsx

mdefazio · 2021-10-14T14:38:12Z

...triggers_actions_ui/public/application/sections/alert_details/components/alert_instances.tsx

+                <EuiHealth
+                  data-test-subj={`ruleStatus-${alert.executionStatus.status}`}
+                  textSize="inherit"
+                  color={healthColor}


Looks like in the screenshot that the 'health' color doesn't match what is shown in the table. (Looks like primary in the table and healthy here).

This health color relates to the rule execution and the color in the table relates to whether the alert for the rule is active or recovered. They are two different things.

I guess it is confusing that they both say active and they are different colors.....but this color lines up with the color on the Rule Management List view

...triggers_actions_ui/public/application/sections/alert_details/components/alert_instances.tsx

ymao1 · 2021-10-14T16:18:26Z

@mdefazio Updated and updated the screenshots as well

chrisronline

LGTM! One small nit but great work here!

x-pack/plugins/triggers_actions_ui/public/application/lib/execution_duration_utils.ts

...triggers_actions_ui/public/application/sections/alert_details/components/alert_instances.tsx

mdefazio

Thanks for making these last minute edits!

YulNaumenko

LGTM. I think it would be useful to expose the charts functionality as a separate (maybe reusable) component, but this could be done in the follow up issue. Don't want to block you with this suggestion.

…ing/show-durations-rule-details

x-pack/plugins/triggers_actions_ui/public/application/lib/execution_duration_utils.ts

kibanamachine · 2021-10-14T19:48:57Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`triggersActionsUi`	376	378	+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`alerting`	249	250	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	787.4KB	793.5KB	+6.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	50.6KB	50.8KB	+119.0B

Unknown metric groups

API count

id	before	after	diff
`alerting`	257	258	+1

History

💚 Build #161025 succeeded 1ab98b0
💚 Build #161018 succeeded efe2100
💚 Build #160907 succeeded 27635e6
💚 Build #160767 succeeded 77be7dd
💛 Build #160736 was flaky 19f4e0c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

kibanamachine · 2021-10-14T19:55:25Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* Adding execution duration to get alert instance summary * Showing execution duration on rule details view * Fixing unit tests * Updating to match new mockup * Fixing types * Fixing functional test * Removing unneeded max and min and adding tests * Removing unneeded max and min and adding tests * Fixing functional test * Adding left axis * PR feedback * Reducing chart height * PR feedback * PR feedback * PR feedback

…15092) * Adding execution duration to get alert instance summary * Showing execution duration on rule details view * Fixing unit tests * Updating to match new mockup * Fixing types * Fixing functional test * Removing unneeded max and min and adding tests * Removing unneeded max and min and adding tests * Fixing functional test * Adding left axis * PR feedback * Reducing chart height * PR feedback * PR feedback * PR feedback Co-authored-by: ymao1 <ying.mao@elastic.co>

* Adding execution duration to get alert instance summary * Showing execution duration on rule details view * Fixing unit tests * Updating to match new mockup * Fixing types * Fixing functional test * Removing unneeded max and min and adding tests * Removing unneeded max and min and adding tests * Fixing functional test * Adding left axis * PR feedback * Reducing chart height * PR feedback * PR feedback * PR feedback

ymao1 added 14 commits October 12, 2021 13:57

Adding execution duration to get alert instance summary

dbe018c

Showing execution duration on rule details view

f3eb183

Merge branch 'master' of https://github.com/elastic/kibana into alert…

c049bb2

…ing/show-durations-rule-details

Fixing unit tests

3a9923f

Updating to match new mockup

7ee6afc

Merge branch 'master' of https://github.com/elastic/kibana into alert…

3f9825d

…ing/show-durations-rule-details

Fixing types

ae6e1dd

Fixing functional test

19f4e0c

Removing unneeded max and min and adding tests

c67502b

Removing unneeded max and min and adding tests

c103eef

Merge branch 'master' of https://github.com/elastic/kibana into alert…

ae4111f

…ing/show-durations-rule-details

Fixing functional test

77be7dd

Adding left axis

dfbfc8f

Merge branch 'master' of https://github.com/elastic/kibana into alert…

27635e6

…ing/show-durations-rule-details

ymao1 changed the title ~~Alerting/show durations rule details~~ [Alerting] Show execution duration on Rule Details view Oct 14, 2021

ymao1 self-assigned this Oct 14, 2021

ymao1 added Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework release_note:enhancement Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.16.0 v8.0.0 labels Oct 14, 2021

ymao1 marked this pull request as ready for review October 14, 2021 13:38

ymao1 requested review from a team as code owners October 14, 2021 13:38

ymao1 requested a review from mdefazio October 14, 2021 13:38

ymao1 commented Oct 14, 2021

View reviewed changes

This was referenced Oct 14, 2021

[Alerting] Retrieve exact number of executions to show in Rule Details view. #115023

Closed

[alerting] change instance summary lookback from 60 * rule interval to something shorter #114921

Open

mdefazio requested changes Oct 14, 2021

View reviewed changes

ymao1 added 2 commits October 14, 2021 11:58

PR feedback

efe2100

Reducing chart height

1ab98b0

ymao1 requested a review from mdefazio October 14, 2021 16:18

chrisronline approved these changes Oct 14, 2021

View reviewed changes

x-pack/plugins/triggers_actions_ui/public/application/lib/execution_duration_utils.ts Show resolved Hide resolved

x-pack/plugins/triggers_actions_ui/public/application/lib/execution_duration_utils.ts Outdated Show resolved Hide resolved

YulNaumenko reviewed Oct 14, 2021

View reviewed changes

...triggers_actions_ui/public/application/sections/alert_details/components/alert_instances.tsx Outdated Show resolved Hide resolved

mdefazio approved these changes Oct 14, 2021

View reviewed changes

PR feedback

7823721

YulNaumenko approved these changes Oct 14, 2021

View reviewed changes

ymao1 added 2 commits October 14, 2021 13:10

PR feedback

61cbe88

Merge branch 'master' of https://github.com/elastic/kibana into alert…

1a7b94a

…ing/show-durations-rule-details

ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label Oct 14, 2021

chrisronline reviewed Oct 14, 2021

View reviewed changes

x-pack/plugins/triggers_actions_ui/public/application/lib/execution_duration_utils.ts Outdated Show resolved Hide resolved

PR feedback

54ea467

ymao1 merged commit 5657f80 into elastic:master Oct 14, 2021

kibanamachine mentioned this pull request Oct 14, 2021

[7.x] [Alerting] Show execution duration on Rule Details view (#114719) #115092

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Alerting] Show execution duration on Rule Details view #114719

[Alerting] Show execution duration on Rule Details view #114719

ymao1 commented Oct 12, 2021 •

edited

Loading

elasticmachine commented Oct 14, 2021

ymao1 Oct 14, 2021

ymao1 Oct 14, 2021

mdefazio left a comment

mdefazio Oct 14, 2021

ymao1 Oct 14, 2021

ymao1 Oct 14, 2021

ymao1 Oct 14, 2021

ymao1 commented Oct 14, 2021

chrisronline left a comment

mdefazio left a comment

YulNaumenko left a comment

kibanamachine commented Oct 14, 2021

API count

kibanamachine commented Oct 14, 2021

[Alerting] Show execution duration on Rule Details view #114719

[Alerting] Show execution duration on Rule Details view #114719

Conversation

ymao1 commented Oct 12, 2021 • edited Loading

Summary

Checklist

elasticmachine commented Oct 14, 2021

ymao1 Oct 14, 2021

Choose a reason for hiding this comment

ymao1 Oct 14, 2021

Choose a reason for hiding this comment

mdefazio left a comment

Choose a reason for hiding this comment

mdefazio Oct 14, 2021

Choose a reason for hiding this comment

ymao1 Oct 14, 2021

Choose a reason for hiding this comment

ymao1 Oct 14, 2021

Choose a reason for hiding this comment

ymao1 Oct 14, 2021

Choose a reason for hiding this comment

ymao1 commented Oct 14, 2021

chrisronline left a comment

Choose a reason for hiding this comment

mdefazio left a comment

Choose a reason for hiding this comment

YulNaumenko left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 14, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

kibanamachine commented Oct 14, 2021

💚 Backport successful

ymao1 commented Oct 12, 2021 •

edited

Loading