[Stack Monitoring] fix feature controls functional test #114781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klacabane
added
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
estermv
approved these changes
Oct 13, 2021
| @@ -52,7 +52,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) { | |||
| basePath: '/s/custom_space', | |||
| }); | |||
|
|
|||
| const exists = await find.existsByCssSelector('monitoring-main'); | |||
| const exists = await find.existsByCssSelector('.app-container'); | |||
There was a problem hiding this comment.
This works for now, but maybe we could change it for a test-subj more descriptive?
There was a problem hiding this comment.
Good call, will send a follow-up revision
|
Added a test-subj attribute to both angular and react containers. Ensured tests passed in both modes. |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
matschaffer
pushed a commit
to matschaffer/kibana
that referenced
this pull request
Oct 15, 2021
* fix feature controls functional test * target test-subj attr instead of class
matschaffer
added a commit
that referenced
this pull request
Oct 15, 2021
artem-shelkovnikov
pushed a commit
to artem-shelkovnikov/kibana
that referenced
this pull request
Oct 20, 2021
* fix feature controls functional test * target test-subj attr instead of class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #114638
One test was broken as it was targeting the
monitoring-mainelement that don't exist in react. Updated the test to target the direct child of themonitoring-mainelement which exists in both angular and react versions.Testing
node scripts/functional_tests_server --config x-pack/test/functional/config.jsnode scripts/functional_test_runner --config x-pack/test/functional/config.js --grep "Monitoring app feature controls"