Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] fix beats pages test-subj attributes #114835

Merged
merged 2 commits into from
Oct 13, 2021
Merged

[Stack Monitoring] fix beats pages test-subj attributes #114835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c5f2b3
fix beats pages test-subj attributes
klacabane Oct 13, 2021
6381929
fix eslint errors
klacabane Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions x-pack/plugins/monitoring/public/application/pages/beats/beats_template.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,15 @@ export const BeatsTemplate: React.FC<BeatsTemplateProps> = ({ instance, ...props
defaultMessage: 'Overview',
}),
route: '/beats',
testSubj: 'beatsOverviewPage',
});
tabs.push({
id: 'instances',
label: i18n.translate('xpack.monitoring.beatsNavigation.instancesLinkText', {
defaultMessage: 'Instances',
}),
route: '/beats/beats',
testSubj: 'beatsListingPage',
});
} else {
tabs.push({
Expand Down
7 changes: 1 addition & 6 deletions x-pack/plugins/monitoring/public/application/pages/beats/instances.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,7 @@ export const BeatsInstancesPage: React.FC<ComponentProps> = ({ clusters }) => {
]);

return (
<BeatsTemplate
title={title}
pageTitle={pageTitle}
getPageData={getPageData}
data-test-subj="beatsListingPage"
>
<BeatsTemplate title={title} pageTitle={pageTitle} getPageData={getPageData}>
<div data-test-subj="monitoringBeatsInstancesApp">
<SetupModeRenderer
productName={BEATS_SYSTEM_ID}
Expand Down
9 changes: 2 additions & 7 deletions x-pack/plugins/monitoring/public/application/pages/beats/overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,8 @@ export const BeatsOverviewPage: React.FC<ComponentProps> = ({ clusters }) => {
};

return (
<BeatsTemplate
title={title}
pageTitle={pageTitle}
getPageData={getPageData}
data-test-subj="beatsOverviewPage"
>
<div data-test-subj="beatsOverviewPage">{renderOverview(data)}</div>
<BeatsTemplate title={title} pageTitle={pageTitle} getPageData={getPageData}>
<div>{renderOverview(data)}</div>
</BeatsTemplate>
);
};