Change expected data to match change in table UI #11495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
approved these changes
Apr 28, 2017
spalger
suggested changes
Apr 28, 2017
| @@ -109,7 +109,7 @@ export default function ({ getService, getPageObjects }) { | |||
|
|
|||
| it('should show correct data, ordered by Term', function () { | |||
|
|
|||
| const expectedChartData = ['png 1,373', 'php 445', 'jpg 9,109', 'gif 918', 'css 2,159']; | |||
| const expectedChartData = ['png', '1,373', 'php', '445', 'jpg', '9,109', 'gif', '918', 'css 2,159']; | |||
There was a problem hiding this comment.
yep, I see that in the failed test. Checked in now
spalger
approved these changes
Apr 28, 2017
added 4 commits
April 28, 2017 12:41
|
Looks like this is passing now @LeeDr ! |
|
@LeeDr I added version labels for 6, 5.5, and 5.4.1 FYI. |
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Apr 28, 2017
* Change expected data to match change in table UI * fix more expected results for data UI change * Revert one previous change and fix one other test * fix last issues * missed splitting the last array element * missed splitting the last array element
Merged
|
This needs a backport to 5.5 as well |
LeeDr
pushed a commit
to LeeDr/kibana
that referenced
this pull request
Apr 28, 2017
* Change expected data to match change in table UI * fix more expected results for data UI change * Revert one previous change and fix one other test * fix last issues * missed splitting the last array element * missed splitting the last array element
Merged
LeeDr
pushed a commit
that referenced
this pull request
Apr 28, 2017
* Change expected data to match change in table UI * fix more expected results for data UI change * Revert one previous change and fix one other test * fix last issues * missed splitting the last array element * missed splitting the last array element
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test that I think was broken by #11452