[Workplace Search] Fix loading state bug and update button #115068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this instead of having the button loading
scottybollinger
added
bug
yakhinvadim
approved these changes
Oct 14, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2021
…15068) * Change source deletion to set entire page loading Do this instead of having the button loading * Replace text button with icon button for blocked windows
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2021
…115094) * Change source deletion to set entire page loading Do this instead of having the button loading * Replace text button with icon button for blocked windows Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
artem-shelkovnikov
pushed a commit
to artem-shelkovnikov/kibana
that referenced
this pull request
Oct 20, 2021
…15068) * Change source deletion to set entire page loading Do this instead of having the button loading * Replace text button with icon button for blocked windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/elastic/workplace-search-team/issues/2114
Summary
This PR fixes an issue where 2 buttons were both loading on the source settings page. We now show the entire page as loading until the source is deleted.
Also, the text button on the Source Synchronization blocked windows table row has been replaced with an icon button:
Checklist