Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workplace Search] Update copy and move links inline for Sync Scheduling #115081

Merged
merged 2 commits into from
Oct 15, 2021
Merged

[Workplace Search] Update copy and move links inline for Sync Scheduling #115081

merged 2 commits into from
Oct 15, 2021

Conversation

scottybollinger
Copy link
Contributor

@scottybollinger scottybollinger commented Oct 14, 2021 •
edited
Loading

closes https://github.com/elastic/workplace-search-team/issues/1945
closes https://github.com/elastic/workplace-search-team/issues/2053

Summary

Update copy and move links inline for Sync Scheduling

sync

freq

objects

Checklist

@scottybollinger scottybollinger added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Oct 14, 2021
@scottybollinger scottybollinger requested a review from a team October 14, 2021 18:37
yakhinvadim
yakhinvadim approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@yakhinvadim yakhinvadim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.4MB 1.4MB -502.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@scottybollinger scottybollinger merged commit a41cee1 into elastic:master Oct 15, 2021
@scottybollinger scottybollinger deleted the scottybollinger/ss-copy-updates branch October 15, 2021 13:23
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 15, 2021
@scottybollinger @kibanamachine
[Workplace Search] Update copy and move links inline for Sync Schedul…
eacee95 
…ing (elastic#115081)
@kibanamachine kibanamachine mentioned this pull request Oct 15, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 15, 2021
@kibanamachine @scottybollinger
[Workplace Search] Update copy and move links inline for Sync Schedul…
19344f0 
…ing (#115081) (#115189)

Co-authored-by: Scotty Bollinger <scotty.bollinger@elastic.co>
artem-shelkovnikov pushed a commit to artem-shelkovnikov/kibana that referenced this pull request Oct 20, 2021
@scottybollinger @artem-shelkovnikov
[Workplace Search] Update copy and move links inline for Sync Schedul…
96c2b6c 
…ing (elastic#115081)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakhinvadim yakhinvadim yakhinvadim approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottybollinger @kibanamachine @yakhinvadim