Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade Assistant] Fix test errors #115183

Merged
merged 2 commits into from
Oct 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/plugins/es_ui_shared/public/request/use_request.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,13 @@ export const useRequest = <D = any, E = Error>(
: serializedResponseData;
setData(responseData);
}
// Setting isLoading to false also acts as a signal for scheduling the next poll request.
setIsLoading(false);
// There can be situations in which a component that consumes this hook gets unmounted when
// the request returns an error. So before changing the isLoading state, check if the component
// is still mounted.
if (isMounted.current === true) {
// Setting isLoading to false also acts as a signal for scheduling the next poll request.
setIsLoading(false);
}
},
[requestBody, httpClient, deserializer, clearPollInterval]
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const Step: React.FunctionComponent<StepProgressStep & { idx: number }> = ({
<Fragment>
<div className="upgStepProgress__step">
<StepStatus status={status} idx={idx} />
<p className={titleClassName}>{title}</p>
<div className={titleClassName}>{title}</div>
</div>
{children && <div className="upgStepProgress__content">{children}</div>}
</Fragment>
Expand Down