Fix flaky functional test in saved objects managements -> delete SO #115291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinaHeiligers
added
Feature:Saved Objects Management
release_note:skip
TinaHeiligers
commented
Oct 16, 2021
test/functional/apps/saved_objects_management/inspect_saved_objects.ts
Outdated
Show resolved
Hide resolved
TinaHeiligers
commented
Oct 16, 2021
test/functional/apps/saved_objects_management/inspect_saved_objects.ts
Outdated
Show resolved
Hide resolved
TinaHeiligers
commented
Oct 16, 2021
test/functional/apps/saved_objects_management/inspect_saved_objects.ts
Outdated
Show resolved
Hide resolved
TinaHeiligers
commented
Oct 16, 2021
test/functional/apps/saved_objects_management/inspect_saved_objects.ts
Outdated
Show resolved
Hide resolved
TinaHeiligers
commented
Oct 16, 2021
test/functional/apps/saved_objects_management/inspect_saved_objects.ts
Outdated
Show resolved
Hide resolved
TinaHeiligers
commented
Oct 16, 2021
test/functional/apps/saved_objects_management/inspect_saved_objects.ts
Outdated
Show resolved
Hide resolved
TinaHeiligers
commented
Oct 16, 2021
test/functional/apps/saved_objects_management/inspect_saved_objects.ts
Outdated
Show resolved
Hide resolved
TinaHeiligers
commented
Oct 16, 2021
|
Flaky test runner ref: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/2057 |
|
@elasticmachine merge upstream |
TinaHeiligers
changed the title
TinaHeiligers
added
the
Team:Core
|
@elasticmachine merge upstream |
This comment has been minimized.
This comment has been minimized.
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-core (Team:Core) |
pgayvallet
approved these changes
Oct 21, 2021
TinaHeiligers
added
the
auto-backport
TinaHeiligers
deleted the
kbn-functional/fix-delete-so-from-so-management
branch
💔 Backport failed
To backport manually run: |
TinaHeiligers
removed
auto-backport
shivindera
pushed a commit
to shivindera/kibana
that referenced
this pull request
Oct 25, 2021
…lastic#115291) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
TinaHeiligers
added
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #68400
Increases retry time to attempt to mitigate the race condition that might be making this test flaky.
Introduces a new helper to wait for the Saved Object to render in the Inspect view before deleting it.
The original work for changing the edit view to a read-only json view only targeted 8.0.0.
To fix the failing test on 7.16, we'll need to cut a new PR to 7.16 directly.
Checklist
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: